-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update httpHeaderNameString() to return an ASCIILiteral #14360
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
cdumez:257343_httpHeaderNameString
May 26, 2023
Merged
Update httpHeaderNameString() to return an ASCIILiteral #14360
webkit-commit-queue
merged 1 commit into
WebKit:main
from
cdumez:257343_httpHeaderNameString
May 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
added
the
WebCore Misc.
For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
label
May 25, 2023
EWS run on previous version of this PR (hash 9d6ea2a) |
cdumez
force-pushed
the
257343_httpHeaderNameString
branch
from
May 25, 2023 20:23
9d6ea2a
to
90e098d
Compare
EWS run on previous version of this PR (hash 90e098d) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 25, 2023
cdumez
force-pushed
the
257343_httpHeaderNameString
branch
from
May 25, 2023 22:25
90e098d
to
a1e3bc6
Compare
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 26, 2023
cdumez
requested review from
youennf,
geoffreygaren,
darinadler and
achristensen07
May 26, 2023 01:26
youennf
approved these changes
May 26, 2023
https://bugs.webkit.org/show_bug.cgi?id=257343 Reviewed by Youenn Fablet. Update httpHeaderNameString() to return an ASCIILiteral instead of a StringView. It makes it clearer that it only returns ASCII characters and that they are "immortal". * Source/WTF/wtf/text/StringHash.h: (WTF::HashTranslatorASCIILiteral::hash): (WTF::HashTranslatorASCIILiteral::equal): (WTF::HashTranslatorASCIILiteral::translate): (WTF::HashTranslatorASCIILiteralCaseInsensitive::hash): (WTF::HashTranslatorASCIILiteralCaseInsensitive::equal): * Source/WTF/wtf/text/WTFString.h: (WTF::HashTranslatorASCIILiteral::hash): Deleted. (WTF::HashTranslatorASCIILiteral::equal): Deleted. (WTF::HashTranslatorASCIILiteral::translate): Deleted. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::handleMessage): * Source/WebCore/platform/network/HTTPHeaderMap.h: (WebCore::HTTPHeaderMap::HTTPHeaderMapConstIterator::updateKeyValue): * Source/WebCore/platform/network/HTTPParsers.cpp: (WebCore::isCrossOriginSafeHeader): * Source/WebCore/platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::sanitizeHTTPHeaderFieldsAccordingToTainting): * Source/WebCore/platform/network/create-http-header-name-table: Canonical link: https://commits.webkit.org/264587@main
webkit-commit-queue
force-pushed
the
257343_httpHeaderNameString
branch
from
May 26, 2023 16:33
a1e3bc6
to
fa60194
Compare
Committed 264587@main (fa60194): https://commits.webkit.org/264587@main Reviewed commits have been landed. Closing PR #14360 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
WebCore Misc.
For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fa60194
a1e3bc6