[results.webkit.org] Display elapsed hours for long runs #14361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
added
the
Tools / Tests
|
EWS run on current version of this PR (hash b367e72) |
aj062
approved these changes
May 26, 2023
aj062
reviewed
May 26, 2023
| if (time.getMinutes()) | ||
| result += `${time.getMinutes()} minute${time.getMinutes() == 1 ? '' : 's'} and `; | ||
| result += `${time.getSeconds()} second${time.getSeconds() == 1 ? '' : 's'} to run`; | ||
| const elapsed = Math.round(endTimestamp - startTimestamp); |
There was a problem hiding this comment.
can make it a separate method as well, e.g.: convertSecondsToReadableDuration
JonWBedard
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=257344 rdar://109849743 Reviewed by Aakash Jain. * Tools/Scripts/libraries/resultsdbpy/resultsdbpy/view/static/js/common.js: Convert elapsed seconds to a human-readable time without using the Date class. Canonical link: https://commits.webkit.org/264589@main
webkit-commit-queue
force-pushed
the
eng/results-webkit-org-Display-elapsed-hours-for-long-runs
branch
from
b367e72
to
413f417
Compare
|
Committed 264589@main (413f417): https://commits.webkit.org/264589@main Reviewed commits have been landed. Closing PR #14361 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
JonWBedard
deleted the
eng/results-webkit-org-Display-elapsed-hours-for-long-runs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
413f417
b367e72
🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-gtk🧪 mac-AS-debug-wk2