-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Password protected PDFs should emit password-related navigation delegate methods #14379
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
hortont424:eng/Password-protected-PDFs-should-emit-password-related-navigation-delegate-methods
May 26, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hortont424
added
the
WebKit Misc.
For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
label
May 26, 2023
aprotyas
reviewed
May 26, 2023
EWS run on previous version of this PR (hash f41d313) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
May 26, 2023
hortont424
removed
the
merging-blocked
Applied to prevent a change from being merged
label
May 26, 2023
rr-codes
approved these changes
May 26, 2023
hortont424
force-pushed
the
eng/Password-protected-PDFs-should-emit-password-related-navigation-delegate-methods
branch
from
May 26, 2023 18:09
f41d313
to
8bc0b78
Compare
pxlcoder
approved these changes
May 26, 2023
EWS run on current version of this PR (hash 8bc0b78) |
whsieh
approved these changes
May 26, 2023
megangardner
approved these changes
May 26, 2023
β¦ate methods https://bugs.webkit.org/show_bug.cgi?id=257364 rdar://109858534 Reviewed by Megan Gardner, Wenson Hsieh and Aditya Keerthi. * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h: * Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _showPasswordViewWithDocumentName:passwordHandler:]): (-[WKWebView _hidePasswordView]): (-[WKWebView _didRequestPasswordForDocument]): (-[WKWebView _didStopRequestingPasswordForDocument]): * Source/WebKit/UIProcess/Cocoa/NavigationState.h: * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::setNavigationDelegate): * Source/WebKit/UIProcess/ios/PageClientImplIOS.mm: (WebKit::PageClientImpl::requestPasswordForQuickLookDocument): Make the password-related navigation delegates exist on all IOS_FAMILY, not just where USE(QUICKLOOK) is true, and adopt them for WKPDFView as well. Despite the names being QuickLook-specific, clients generally want to do the same things when a password field is up regardless of whether it's up for PDF or QuickLook reasons. * Source/WebKit/UIProcess/ios/WKPDFView.mm: (-[WKPDFView web_initWithFrame:webView:mimeType:]): (-[WKPDFView updateBackgroundColor]): Drive-by; update the background color when entering and exiting the password view. (-[WKPDFView pdfHostViewControllerDocumentDidRequestPassword:]): (-[WKPDFView pdfHostViewController:documentDidUnlockWithPassword:]): Call the navigation delegate. Canonical link: https://commits.webkit.org/264600@main
webkit-commit-queue
force-pushed
the
eng/Password-protected-PDFs-should-emit-password-related-navigation-delegate-methods
branch
from
May 26, 2023 19:48
8bc0b78
to
3fec0ec
Compare
Committed 264600@main (3fec0ec): https://commits.webkit.org/264600@main Reviewed commits have been landed. Closing PR #14379 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
WebKit Misc.
For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3fec0ec
8bc0b78
π wincairoπ§ͺ gtk-wk2π§ͺ mac-wk2