Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically added custom scrollbar styles don't apply #14386

Merged
merged 1 commit into from Jun 9, 2023
Merged

Dynamically added custom scrollbar styles don't apply #14386

merged 1 commit into from Jun 9, 2023

Conversation

obyknovenius
Copy link
Contributor

@obyknovenius obyknovenius commented May 26, 2023 •
edited by webkit-early-warning-system

1ac712c

Dynamically added custom scrollbar styles don't apply
https://bugs.webkit.org/show_bug.cgi?id=211219

Reviewed by Antti Koivisto.

`::-webkit-scrollbar` pseudo-element should be resolved eagerly during
style resolution, similar to `::first-line` and `::first-letter`.

* LayoutTests/fast/css/scrollbar-custom-dynamic-change-expected.html: Added.
* LayoutTests/fast/css/scrollbar-custom-dynamic-change.html: Added.
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):

Canonical link: https://commits.webkit.org/265015@main

a3595f5

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@obyknovenius obyknovenius self-assigned this May 26, 2023
@obyknovenius obyknovenius added the CSS Cascading Style Sheets implementation label May 26, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 96a9ff5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 requested a review from nt1m May 26, 2023 10:25
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 26, 2023
@aproskuryakov aproskuryakov requested a review from smfr May 26, 2023 16:06
@obyknovenius obyknovenius removed the merging-blocked Applied to prevent a change from being merged label May 30, 2023
@obyknovenius obyknovenius force-pushed the fix/custom-scrollbar-dynamic-change branch from 96a9ff5 to 3d0de4c Compare May 30, 2023 15:58
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 3d0de4c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 30, 2023
@obyknovenius obyknovenius removed the merging-blocked Applied to prevent a change from being merged label May 31, 2023
@obyknovenius obyknovenius force-pushed the fix/custom-scrollbar-dynamic-change branch from 3d0de4c to ecaba8b Compare June 1, 2023 10:54
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash ecaba8b)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 1, 2023
@obyknovenius obyknovenius removed the merging-blocked Applied to prevent a change from being merged label Jun 8, 2023
@obyknovenius obyknovenius force-pushed the fix/custom-scrollbar-dynamic-change branch from ecaba8b to a3595f5 Compare June 8, 2023 15:03
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash a3595f5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk
Copy link
Contributor

anttijk commented Jun 9, 2023

looks good

@obyknovenius obyknovenius added the merge-queue Applied to send a pull request to merge-queue label Jun 9, 2023
@obyknovenius
Dynamically added custom scrollbar styles don't apply
1ac712c 
https://bugs.webkit.org/show_bug.cgi?id=211219

Reviewed by Antti Koivisto.

`::-webkit-scrollbar` pseudo-element should be resolved eagerly during
style resolution, similar to `::first-line` and `::first-letter`.

* LayoutTests/fast/css/scrollbar-custom-dynamic-change-expected.html: Added.
* LayoutTests/fast/css/scrollbar-custom-dynamic-change.html: Added.
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):

Canonical link: https://commits.webkit.org/265015@main
@webkit-commit-queue webkit-commit-queue force-pushed the fix/custom-scrollbar-dynamic-change branch from a3595f5 to 1ac712c Compare June 9, 2023 10:56
@webkit-commit-queue
Copy link
Collaborator

Committed 265015@main (1ac712c): https://commits.webkit.org/265015@main

Reviewed commits have been landed. Closing PR #14386 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1ac712c into WebKit:main Jun 9, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 9, 2023
@obyknovenius obyknovenius deleted the fix/custom-scrollbar-dynamic-change branch June 9, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttijk anttijk anttijk approved these changes

@graouts graouts Awaiting requested review from graouts

@nt1m nt1m Awaiting requested review from nt1m

@smfr smfr Awaiting requested review from smfr

Assignees

@obyknovenius obyknovenius

Labels
CSS Cascading Style Sheets implementation
Projects
None yet
Milestone
No milestone
5 participants
@obyknovenius @webkit-early-warning-system @anttijk @webkit-commit-queue @webkit-ews-buildbot