Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also block logd in internal builds #14394

Merged
merged 1 commit into from
May 30, 2023
Merged

Also block logd in internal builds #14394

merged 1 commit into from
May 30, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented May 26, 2023 •
edited by webkit-early-warning-system

38a1b59

Also block logd in internal builds
https://bugs.webkit.org/show_bug.cgi?id=257383
rdar://109891488

Reviewed by Brent Fulgham.

Also block logd in internal builds to unify logging behavior.

* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::launchProcess):

Canonical link: https://commits.webkit.org/264685@main

f2d53e4

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
  🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pvollan pvollan requested a review from cdumez as a code owner May 26, 2023 16:08
@pvollan pvollan self-assigned this May 26, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label May 26, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash f2d53e4)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
  🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 26, 2023
@pvollan pvollan removed the merging-blocked Applied to prevent a change from being merged label May 30, 2023
brentfulgham
brentfulgham approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@pvollan pvollan added the merge-queue Applied to send a pull request to merge-queue label May 30, 2023
@pvollan
Copy link
Contributor Author

pvollan commented May 30, 2023

r=me

Thanks for reviewing!

@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 30, 2023
@pvollan
Also block logd in internal builds
38a1b59 
https://bugs.webkit.org/show_bug.cgi?id=257383
rdar://109891488

Reviewed by Brent Fulgham.

Also block logd in internal builds to unify logging behavior.

* Source/WebKit/UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:
(WebKit::ProcessLauncher::launchProcess):

Canonical link: https://commits.webkit.org/264685@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Also-block-logd-in-internal-builds branch from f2d53e4 to 38a1b59 Compare May 30, 2023 18:17
@webkit-commit-queue
Copy link
Collaborator

Committed 264685@main (38a1b59): https://commits.webkit.org/264685@main

Reviewed commits have been landed. Closing PR #14394 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 38a1b59 into WebKit:main May 30, 2023
@webkit-commit-queue webkit-commit-queue removed merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
5 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @brentfulgham @webkit-ews-buildbot