[EWS] Support PRs when sending build failure emails (Follow-up fix) #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
force-pushed
the
eng/github-ews-log-owner-errors
branch
from
5be02e0
to
f2e33dc
Compare
aj062
approved these changes
Feb 15, 2022
Tools/CISupport/ews-build/steps.py
Outdated
| @@ -2168,7 +2167,7 @@ def send_email_for_new_build_failure(self): | |||
| if pr_number and not self.should_send_email_for_pr(pr_number): | |||
| return | |||
| if not patch_id and not (pr_number and sha): | |||
| print('Unrecognized change type') | |||
| self._addToLog('Unrecognized change type') | |||
There was a problem hiding this comment.
I don't think we will ever hit it. Some other steps will check similar check fail much earlier. But that's ok print to UI here as well.
Tools/CISupport/ews-build/steps.py
Outdated
|
|
||
| if not change_author: | ||
| print('Failed to determine change author for hash {} belonging to PR #{}'.format(sha, patch_id)) | ||
| self._addToLog('Failed to determine change author for hash {} belonging to PR #{}'.format(sha, patch_id)) |
There was a problem hiding this comment.
Might want to mention something about contributors.json as well. So that people know what they can do to fix it. Might want to include github username in this message as well. Something like:
Unable to determine email address for [github_username] from contributors.json. Skipping sending email.
JonWBedard
force-pushed
the
eng/github-ews-log-owner-errors
branch
from
f2e33dc
to
15e21e6
Compare
|
Left a comment: 15e21e6#r66766126 |
JonWBedard
added
Tools / Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
15e21e6