Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WGSL] AST::Builder needs to shrink nodes when restoring state #14456

Conversation

tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented May 29, 2023

c94bdc5

[WGSL] AST::Builder needs to shrink nodes when restoring state
https://bugs.webkit.org/show_bug.cgi?id=257457
rdar://109974514

Reviewed by Myles C. Maxfield.

When restoring the previous state of the AST builder we free the nodes that were
allocated during the current compilation, but we also need to remove them from
m_nodes, otherwise they'll be freed multiple times.

* Source/WebGPU/WGSL/AST/ASTBuilder.cpp:
(WGSL::AST::Builder::restore):

Canonical link: https://commits.webkit.org/264663@main

66752d7

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@tadeuzagallo tadeuzagallo self-assigned this May 29, 2023
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label May 29, 2023
@litherum
Copy link
Contributor

no test?

@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label May 30, 2023
https://bugs.webkit.org/show_bug.cgi?id=257457
rdar://109974514

Reviewed by Myles C. Maxfield.

When restoring the previous state of the AST builder we free the nodes that were
allocated during the current compilation, but we also need to remove them from
m_nodes, otherwise they'll be freed multiple times.

* Source/WebGPU/WGSL/AST/ASTBuilder.cpp:
(WGSL::AST::Builder::restore):

Canonical link: https://commits.webkit.org/264663@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-ASTBuilder-needs-to-shrink-nodes-when-restoring-state branch from 66752d7 to c94bdc5 Compare May 30, 2023 07:19
@webkit-commit-queue
Copy link
Collaborator

Committed 264663@main (c94bdc5): https://commits.webkit.org/264663@main

Reviewed commits have been landed. Closing PR #14456 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c94bdc5 into WebKit:main May 30, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
4 participants