jsc.exe --module-file should understand Windows paths

[rkirsling]

47fde25

jsc.exe --module-file should understand Windows paths
https://bugs.webkit.org/show_bug.cgi?id=241518

Reviewed by Yusuke Suzuki.

jsc.cpp's module loader was written without any accommodation for Windows, so:
1. On Windows, recognize C:\foo as an absolute path and .\foo and ..\foo as dotted relative paths (allowing '/' too).
2. On all platforms, stop misusing the URL(base, relative) constructor. This isn't the way to add file:/// to an abspath.

This ensures that module tests are able to run well on Windows.

* Source/JavaScriptCore/jsc.cpp:
(isAbsolutePath): Added.
(isDottedRelativePath): Added.
(absoluteFileURL): Renamed from `absolutePath`.
(GlobalObject::moduleLoaderImportModule):
(GlobalObject::moduleLoaderResolve):
(JSC_DEFINE_HOST_FUNCTION):
(computeFilePath):
(runWithOptions):

Canonical link: https://commits.webkit.org/251514@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Constellation]

r=me

[Constellation]

Since it is used for module specifier too, I think / root path should be supported too in Windows. And in that case, we should make a path from the current path's drive.

[rkirsling]

Hmm, are you sure? It seems like other engines still treat that as a relative path on Windows:

test.js

import result from '/GitHub/WebKit/test-module.js';
print(result);

Result:

PS C:\GitHub\WebKit> ~\.jsvu\v8.cmd --module test.js
undefined:0: Error: d8: Error reading  module from C:/GitHub/WebKit//GitHub/WebKit/test-module.js
    imported by C:/GitHub/WebKit/test.js

PS C:\GitHub\WebKit> ~\.jsvu\sm.cmd --module test.js
Error: can't open C:\GitHub\WebKit\\GitHub\WebKit\test-module.js: No such file or directory
Stack:

[webkit-early-warning-system]

Committed r295509 (251514@main): https://commits.webkit.org/251514@main

Reviewed commits have been landed. Closing PR #1449 and removing active labels.