Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust pixel tolerance for compositing/scrolling/async-overflow-scrolling/border-radius-on-scroll-container.html #14518

Conversation

karlrackler
Copy link
Contributor

@karlrackler karlrackler commented May 31, 2023

@karlrackler karlrackler self-assigned this May 31, 2023
@karlrackler karlrackler added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label May 31, 2023
@karlrackler karlrackler requested a review from smfr May 31, 2023 02:01
@karlrackler karlrackler force-pushed the eng/Adjust-pixel-tolerance-for-compositingscrollingasync-overflow-scrollingborder-radius-on-scroll-container-html branch from 38a4ab4 to 78c4220 Compare May 31, 2023 02:11
@karlrackler karlrackler added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 31, 2023
@webkit-commit-queue
Copy link
Collaborator

No reviewer information in commit message, blocking PR #14518

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels May 31, 2023
@karlrackler karlrackler removed the merging-blocked Applied to prevent a change from being merged label May 31, 2023
@karlrackler karlrackler force-pushed the eng/Adjust-pixel-tolerance-for-compositingscrollingasync-overflow-scrollingborder-radius-on-scroll-container-html branch from 78c4220 to 68758e3 Compare May 31, 2023 02:23
@karlrackler karlrackler added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 31, 2023
…ling/border-radius-on-scroll-container.html

https://bugs.webkit.org/show_bug.cgi?id=257518
rdar://110039194

Reviewed by Tim Nguyen.

This adjust pixel tolerance for maxDifference as needed by actual result.

* LayoutTests/compositing/scrolling/async-overflow-scrolling/border-radius-on-scroll-container.html:

Canonical link: https://commits.webkit.org/264707@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Adjust-pixel-tolerance-for-compositingscrollingasync-overflow-scrollingborder-radius-on-scroll-container-html branch from 68758e3 to 8317c9a Compare May 31, 2023 02:26
@webkit-commit-queue
Copy link
Collaborator

Committed 264707@main (8317c9a): https://commits.webkit.org/264707@main

Reviewed commits have been landed. Closing PR #14518 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8317c9a into WebKit:main May 31, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
4 participants