-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TextBreakIterator's API to support prior context #14530
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
litherum:eng/Update-TextBreakIterators-API-to-support-prior-context
Jun 1, 2023
Merged
Update TextBreakIterator's API to support prior context #14530
webkit-commit-queue
merged 1 commit into
WebKit:main
from
litherum:eng/Update-TextBreakIterators-API-to-support-prior-context
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litherum
added
the
Text
For bugs in text layout and rendering, including international text support.
label
May 31, 2023
Constellation
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
https://bugs.webkit.org/show_bug.cgi?id=257529 <rdar://problem/110051433> Reviewed by Yusuke Suzuki. Now that TextBreakIteratorCF and TextBreakIteratorICU both support prior context, we can hook it up to TextBreakIterator's API. After this patch, all the features supported by LazyLineBreakIterator are supported by TextBreakIterator, so we can switch over from from using LazyLineBreakIterator to TextBreakIterator whenever we want. However, before making the switch, we still need to determine if there is a performance cost to doing so. * Source/WTF/wtf/text/TextBreakIterator.cpp: (WTF::TextBreakIterator::mapModeToBackingIterator): (WTF::TextBreakIterator::TextBreakIterator): * Source/WTF/wtf/text/TextBreakIterator.h: (WTF::TextBreakIterator::setText): (WTF::TextBreakIteratorCache::take): (WTF::CachedTextBreakIterator::CachedTextBreakIterator): * Source/WTF/wtf/text/cocoa/TextBreakIteratorInternalICUCocoa.cpp: (WTF::TextBreakIterator::mapModeToBackingIterator): (WTF::TextBreakIterator::TextBreakIterator): * Source/WTF/wtf/text/icu/TextBreakIteratorICU.h: (WTF::TextBreakIteratorICU::TextBreakIteratorICU): * Source/WebCore/platform/graphics/ComplexTextController.cpp: (WebCore::ComplexTextController::offsetForPosition): (WebCore::ComplexTextController::collectComplexTextRuns): * Source/WebCore/platform/graphics/ComposedCharacterClusterTextIterator.h: (WebCore::ComposedCharacterClusterTextIterator::ComposedCharacterClusterTextIterator): * Source/WebCore/rendering/RenderText.cpp: (WebCore::RenderText::previousOffset const): (WebCore::RenderText::previousOffsetForBackwardDeletion const): (WebCore::RenderText::nextOffset const): * Tools/TestWebKitAPI/Tests/WTF/TextBreakIterator.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/264772@main
webkit-commit-queue
force-pushed
the
eng/Update-TextBreakIterators-API-to-support-prior-context
branch
from
June 1, 2023 03:51
c9de2e1
to
531ad5e
Compare
Committed 264772@main (531ad5e): https://commits.webkit.org/264772@main Reviewed commits have been landed. Closing PR #14530 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Jun 1, 2023
litherum
deleted the
eng/Update-TextBreakIterators-API-to-support-prior-context
branch
June 1, 2023 05:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
531ad5e
c9de2e1
π§ͺ api-mac