Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Curl] Simplify event handling in CurlRequest::invokeDidReceiveResponse() #14618

Merged
merged 1 commit into from Jun 2, 2023
Merged

[Curl] Simplify event handling in CurlRequest::invokeDidReceiveResponse() #14618

merged 1 commit into from Jun 2, 2023

Conversation

kshukuwa
Copy link
Contributor

@kshukuwa kshukuwa commented Jun 2, 2023 •
edited by webkit-early-warning-system

ed79ff0

[Curl] Simplify event handling in CurlRequest::invokeDidReceiveResponse()
https://bugs.webkit.org/show_bug.cgi?id=257639

Reviewed by Fujii Hironori.

Replacing the argument of invokeDidReceiveResponse from Action
to Function makes the subsequent processing easier to understand.

* Source/WebCore/platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::didReceiveData):
(WebCore::CurlRequest::didReceiveHeaderFromMultipart):
(WebCore::CurlRequest::didCompleteTransfer):
(WebCore::CurlRequest::invokeDidReceiveResponseForFile):
(WebCore::CurlRequest::invokeDidReceiveResponse):
(WebCore::CurlRequest::completeDidReceiveResponse):
* Source/WebCore/platform/network/curl/CurlRequest.h:
(WebCore::CurlRequest::needToInvokeDidCancelTransfer const):
(WebCore::CurlRequest::invokeDidReceiveResponse):

Canonical link: https://commits.webkit.org/264827@main

09cc4f6

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 16e8a12)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

fujii
fujii reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@fujii fujii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add https://bugs.webkit.org/show_bug.cgi?id=257639#c0 to the commit message.

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 09cc4f6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@kshukuwa
Copy link
Contributor Author

kshukuwa commented Jun 2, 2023

Please add https://bugs.webkit.org/show_bug.cgi?id=257639#c0 to the commit message.

Fixed

@kshukuwa kshukuwa requested a review from fujii June 2, 2023 07:53
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 2, 2023
@kshukuwa
Copy link
Contributor Author

kshukuwa commented Jun 2, 2023

@fujii
Could you apply merge-queue label?

@fujii fujii added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jun 2, 2023
@kshukuwa @fujii
[Curl] Simplify event handling in CurlRequest::invokeDidReceiveRespon…
ed79ff0 
…se()

https://bugs.webkit.org/show_bug.cgi?id=257639

Reviewed by Fujii Hironori.

Replacing the argument of invokeDidReceiveResponse from Action
to Function makes the subsequent processing easier to understand.

* Source/WebCore/platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::didReceiveData):
(WebCore::CurlRequest::didReceiveHeaderFromMultipart):
(WebCore::CurlRequest::didCompleteTransfer):
(WebCore::CurlRequest::invokeDidReceiveResponseForFile):
(WebCore::CurlRequest::invokeDidReceiveResponse):
(WebCore::CurlRequest::completeDidReceiveResponse):
* Source/WebCore/platform/network/curl/CurlRequest.h:
(WebCore::CurlRequest::needToInvokeDidCancelTransfer const):
(WebCore::CurlRequest::invokeDidReceiveResponse):

Canonical link: https://commits.webkit.org/264827@main
@webkit-commit-queue
Copy link
Collaborator

Committed 264827@main (ed79ff0): https://commits.webkit.org/264827@main

Reviewed commits have been landed. Closing PR #14618 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ed79ff0 into WebKit:main Jun 2, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 2, 2023
@kshukuwa kshukuwa deleted the eng/bug257639 branch June 16, 2023 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujii fujii fujii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@kshukuwa @webkit-early-warning-system @webkit-commit-queue @fujii @webkit-ews-buildbot