Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGL in the GPUP should be enabled for watchOS #14646

Merged
merged 1 commit into from Jun 3, 2023
Merged

WebGL in the GPUP should be enabled for watchOS #14646

merged 1 commit into from Jun 3, 2023

Conversation

grorg
Copy link
Contributor

@grorg grorg commented Jun 2, 2023 •
edited by webkit-early-warning-system

058ae53

WebGL in the GPUP should be enabled for watchOS
https://bugs.webkit.org/show_bug.cgi?id=257669
rdar://110191155

Reviewed by Per Arne Vollan and Mike Wyrzykowski.

WebGL in the GPUP should be enabled for watchOS.

* Source/WTF/wtf/PlatformEnable.h:

Canonical link: https://commits.webkit.org/264845@main

5d2bc72

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@grorg grorg self-assigned this Jun 2, 2023
@grorg grorg added the WebGL Bugs in WebKit’s implementation of the WebGL standard. label Jun 2, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 5d2bc72)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

pvollan
pvollan approved these changes Jun 3, 2023
View reviewed changes
Copy link
Contributor

@pvollan pvollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R=me.

@grorg grorg added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 3, 2023
@grorg
WebGL in the GPUP should be enabled for watchOS
058ae53 
https://bugs.webkit.org/show_bug.cgi?id=257669
rdar://110191155

Reviewed by Per Arne Vollan and Mike Wyrzykowski.

WebGL in the GPUP should be enabled for watchOS.

* Source/WTF/wtf/PlatformEnable.h:

Canonical link: https://commits.webkit.org/264845@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGL-in-the-GPUP-should-be-enabled-for-watchOS branch from 5d2bc72 to 058ae53 Compare June 3, 2023 01:34
@webkit-commit-queue
Copy link
Collaborator

Committed 264845@main (058ae53): https://commits.webkit.org/264845@main

Reviewed commits have been landed. Closing PR #14646 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 058ae53 into WebKit:main Jun 3, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 3, 2023
@grorg grorg deleted the eng/WebGL-in-the-GPUP-should-be-enabled-for-watchOS branch June 29, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvollan pvollan pvollan approved these changes

@mwyrzykowski mwyrzykowski mwyrzykowski approved these changes

@kkinnunen-apple kkinnunen-apple Awaiting requested review from kkinnunen-apple

Assignees

@grorg grorg

Labels
WebGL Bugs in WebKit’s implementation of the WebGL standard.
Projects
None yet
Milestone
No milestone
5 participants
@grorg @webkit-early-warning-system @webkit-commit-queue @pvollan @mwyrzykowski