-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebGPU] Delete some unnecessary methods from WebGPUExt.h #14651
[WebGPU] Delete some unnecessary methods from WebGPUExt.h #14651
Conversation
EWS run on previous version of this PR (hash 4a74608) |
4a74608
to
ab62dc0
Compare
EWS run on previous version of this PR (hash ab62dc0) |
ab62dc0
to
6fb03f6
Compare
EWS run on previous version of this PR (hash 6fb03f6) |
6fb03f6
to
1664319
Compare
EWS run on previous version of this PR (hash 1664319) |
1664319
to
a156035
Compare
a156035
to
b44208b
Compare
EWS run on current version of this PR (hash b44208b) |
https://bugs.webkit.org/show_bug.cgi?id=257673 rdar://110201177 Reviewed by Mike Wyrzykowski. The more custom stuff in WebGPUExt.h we have, the more difficult it will be to swap in and out different WebGPU implementations. We generally want to minimize the contents of WebGPUExt.h as much as possible. This patch deletes the fooWithBlock() functions from being exported, in favor of just using the common function pointer + userdata paradigm instead. This patch doesn't actually delete the implementation of the fooWithBlock() functions, because they will probably be useful while implementing WebKit#13849. This patch therefore moves their declaration to a WebGPUInternal.h file, which is not exported. * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp: (PAL::WebGPU::requestDeviceCallback): (PAL::WebGPU::AdapterImpl::requestDevice): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUBufferImpl.cpp: (PAL::WebGPU::mapAsyncCallback): (PAL::WebGPU::BufferImpl::mapAsync): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp: (PAL::WebGPU::createComputePipelineAsyncCallback): (PAL::WebGPU::DeviceImpl::createComputePipelineAsync): (PAL::WebGPU::createRenderPipelineAsyncCallback): (PAL::WebGPU::DeviceImpl::createRenderPipelineAsync): (PAL::WebGPU::popErrorScopeCallback): (PAL::WebGPU::DeviceImpl::popErrorScope): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUImpl.cpp: (PAL::WebGPU::requestAdapterCallback): (PAL::WebGPU::GPUImpl::requestAdapter): * Source/WebCore/PAL/pal/graphics/WebGPU/Impl/WebGPUQueueImpl.cpp: (PAL::WebGPU::onSubmittedWorkDoneCallback): (PAL::WebGPU::QueueImpl::onSubmittedWorkDone): * Source/WebGPU/WebGPU/Adapter.mm: (wgpuAdapterRequestDevice): (wgpuAdapterRequestDeviceWithBlock): Deleted. * Source/WebGPU/WebGPU/Buffer.mm: (wgpuBufferMapAsyncWithBlock): Deleted. * Source/WebGPU/WebGPU/Device.mm: (wgpuDeviceCreateComputePipelineAsyncWithBlock): Deleted. (wgpuDeviceCreateRenderPipelineAsyncWithBlock): Deleted. (wgpuDevicePopErrorScopeWithBlock): Deleted. (wgpuDeviceSetUncapturedErrorCallbackWithBlock): Deleted. * Source/WebGPU/WebGPU/Instance.mm: (wgpuInstanceRequestAdapter): (wgpuInstanceRequestAdapterWithBlock): Deleted. * Source/WebGPU/WebGPU/Queue.mm: (wgpuQueueOnSubmittedWorkDoneWithBlock): Deleted. * Source/WebGPU/WebGPU/ShaderModule.mm: (wgpuShaderModuleGetCompilationInfoWithBlock): Deleted. * Source/WebGPU/WebGPU/WebGPUExt.h: Canonical link: https://commits.webkit.org/264893@main
b44208b
to
5b9c48e
Compare
Committed 264893@main (5b9c48e): https://commits.webkit.org/264893@main Reviewed commits have been landed. Closing PR #14651 and removing active labels. |
5b9c48e
b44208b
π§ͺ api-macπ§ͺ mac-wk1π§ͺ gtk-wk2π§ͺ mac-wk2π§ͺ mac-AS-debug-wk2