New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement scrollbar-gutter both-edges support on non-viewports #14666
Implement scrollbar-gutter both-edges support on non-viewports #14666
Conversation
EWS run on previous version of this PR (hash d8ee448) |
d8ee448
to
e778618
Compare
EWS run on previous version of this PR (hash e778618) |
e778618
to
c3aa87b
Compare
EWS run on previous version of this PR (hash c3aa87b) |
EWS run on previous version of this PR (hash 39173fa) |
This change contains multiple commits which are not squashed together, blocking PR #14666. Please squash the commits to land. |
39173fa
to
7efe6a9
Compare
https://bugs.webkit.org/show_bug.cgi?id=257708 Reviewed by Simon Fraser. Scrollbar gutter now correctly works (on non-viewports) for both the "stable" and "stable both-edges" values. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-rtl-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-lr-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-rl-001-expected.txt: * Source/WebCore/rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::determineLogicalLeftPositionForChild): * Source/WebCore/rendering/RenderBox.cpp: (WebCore::RenderBox::contentBoxLocation const): * Source/WebCore/rendering/RenderBoxInlines.h: (WebCore::RenderBox::computedCSSContentBoxRect const): (WebCore::RenderBox::contentHeight const): (WebCore::RenderBox::contentWidth const): (WebCore::RenderBox::overridingContentLogicalHeight const): (WebCore::RenderBox::overridingContentLogicalWidth const): * Source/WebCore/rendering/style/RenderStyle.h: Canonical link: https://commits.webkit.org/265199@main
7efe6a9
to
9a055c1
Compare
Committed 265199@main (9a055c1): https://commits.webkit.org/265199@main Reviewed commits have been landed. Closing PR #14666 and removing active labels. |
9a055c1
7efe6a9
π§ͺ mac-AS-debug-wk2