[WGSL] Only rewrite globals in callees once #14671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 3818bdb)
|
tadeuzagallo
force-pushed
the
eng/WGSL-Only-rewrite-globals-in-callees-once
branch
from
3818bdb
to
2809df4
Compare
|
EWS run on current version of this PR (hash 2809df4)
|
https://bugs.webkit.org/show_bug.cgi?id=257716 rdar://110265430 Reviewed by Dan Glastonbury. A callee might be reached through multiple paths in the call graph (e.g. f->h and f->g->h), so we need to keep track of the callees we already visited. However, when we encounter a callee we already visited we (might) still need to rewrite all the call sites to that callee if its signature was modified (i.e. if it needs global variable(s) to be passed to it). * Source/WebGPU/WGSL/GlobalVariableRewriter.cpp: (WGSL::RewriteGlobalVariables::visitCallee): * Source/WebGPU/WGSL/tests/valid/global-used-by-callee.wgsl: Canonical link: https://commits.webkit.org/264931@main
webkit-commit-queue
force-pushed
the
eng/WGSL-Only-rewrite-globals-in-callees-once
branch
from
2809df4
to
3d3c9d7
Compare
|
Committed 264931@main (3d3c9d7): https://commits.webkit.org/264931@main Reviewed commits have been landed. Closing PR #14671 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3d3c9d7
2809df4
🛠 wincairo🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-AS-debug-wk2🛠 watch