Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Speedometer3 signpost patch #14686

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Fix Speedometer3 signpost patch #14686

merged 1 commit into from
Jun 6, 2023

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Jun 6, 2023 •
edited by webkit-early-warning-system

@rniwa rniwa requested a review from JonWBedard as a code owner June 6, 2023 00:19
@rniwa rniwa self-assigned this Jun 6, 2023
@rniwa rniwa added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 6, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 0dc3b1f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy   🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
  🛠 tv   🧪 mac-AS-debug-wk2
  🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@xw
Copy link
Contributor

xw commented Jun 6, 2023

LGTM. Looks like the major change here is moving the signposts marks inside runSync/runAsync.

dewei-zhu
dewei-zhu approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@rniwa rniwa added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 6, 2023
@rniwa
Fix Speedometer3 signpost patch
5b1638d 
https://bugs.webkit.org/show_bug.cgi?id=257734

Reviewed by Dewei Zhu.

Updated the Speedometer 3 signpost patch.

* Tools/Scripts/webkitpy/benchmark_runner/data/patches/signposts/Speedometer3.patch:

Canonical link: https://commits.webkit.org/264882@main
@webkit-commit-queue
Copy link
Collaborator

Committed 264882@main (5b1638d): https://commits.webkit.org/264882@main

Reviewed commits have been landed. Closing PR #14686 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 5b1638d into WebKit:main Jun 6, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 6, 2023
@rniwa rniwa deleted the fix257734 branch June 6, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewei-zhu dewei-zhu dewei-zhu approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

@justinmichaud justinmichaud Awaiting requested review from justinmichaud

Assignees

@rniwa rniwa

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
5 participants
@rniwa @webkit-early-warning-system @xw @webkit-commit-queue @dewei-zhu