Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Stop creating microphone sandbox extension #14699

Merged
merged 1 commit into from
Jun 6, 2023
Merged

[macOS] Stop creating microphone sandbox extension #14699

merged 1 commit into from
Jun 6, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Jun 6, 2023 •
edited by webkit-early-warning-system

d8d9573

[macOS] Stop creating microphone sandbox extension
https://bugs.webkit.org/show_bug.cgi?id=257750
rdar://101821075

Reviewed by Youenn Fablet.

After <rdar://problem/29448368> has been resolved, we can stop creating a sandbox extension to microphone for the WebContent process.

* Source/WebKit/Shared/WebProcessCreationParameters.h:
* Source/WebKit/Shared/WebProcessCreationParameters.serialization.in:
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/264905@main

cc1e14d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
  🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@pvollan pvollan requested a review from cdumez as a code owner June 6, 2023 16:16
@pvollan pvollan self-assigned this Jun 6, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jun 6, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash b2b3023)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac   🛠 gtk
  🧪 ios-wk2-wpt   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
⏳ 🛠 tv   🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim
⏳ 🛠 watch
⏳ 🛠 watch-sim

@pvollan pvollan force-pushed the eng/macOS-Stop-creating-microphone-sandbox-extension branch from b2b3023 to a5a0b0e Compare June 6, 2023 16:20
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash a5a0b0e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@pvollan pvollan force-pushed the eng/macOS-Stop-creating-microphone-sandbox-extension branch from a5a0b0e to a4292f7 Compare June 6, 2023 16:43
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash a4292f7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1   🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 mac-wk2   🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim ❌ 🧪 mac-wk2-stress
⏳ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 6, 2023
@pvollan pvollan removed the merging-blocked Applied to prevent a change from being merged label Jun 6, 2023
@pvollan pvollan force-pushed the eng/macOS-Stop-creating-microphone-sandbox-extension branch from a4292f7 to cc1e14d Compare June 6, 2023 16:57
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash cc1e14d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
  🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@pvollan pvollan added the merge-queue Applied to send a pull request to merge-queue label Jun 6, 2023
@pvollan
Copy link
Contributor Author

pvollan commented Jun 6, 2023

Thanks for reviewing!

@pvollan
[macOS] Stop creating microphone sandbox extension
d8d9573 
https://bugs.webkit.org/show_bug.cgi?id=257750
rdar://101821075

Reviewed by Youenn Fablet.

After <rdar://problem/29448368> has been resolved, we can stop creating a sandbox extension to microphone for the WebContent process.

* Source/WebKit/Shared/WebProcessCreationParameters.h:
* Source/WebKit/Shared/WebProcessCreationParameters.serialization.in:
* Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/264905@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/macOS-Stop-creating-microphone-sandbox-extension branch from cc1e14d to d8d9573 Compare June 6, 2023 18:24
@webkit-commit-queue
Copy link
Collaborator

Committed 264905@main (d8d9573): https://commits.webkit.org/264905@main

Reviewed commits have been landed. Closing PR #14699 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d8d9573 into WebKit:main Jun 6, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youennf youennf youennf approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@eric-carlson eric-carlson Awaiting requested review from eric-carlson

@brentfulgham brentfulgham Awaiting requested review from brentfulgham

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
5 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @youennf @webkit-ews-buildbot