Update GB-18030 encoding table #14716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
the
WebCore Misc.
|
EWS run on previous version of this PR (hash c33fe4f) |
achristensen07
force-pushed
the
eng/Update-GB-18030-encoding-table
branch
from
c33fe4f
to
c21e34d
Compare
|
EWS run on previous version of this PR (hash c21e34d) |
achristensen07
force-pushed
the
eng/Update-GB-18030-encoding-table
branch
from
c21e34d
to
dc7d29a
Compare
|
EWS run on current version of this PR (hash dc7d29a) |
litherum
approved these changes
Jun 7, 2023
achristensen07
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=257770 rdar://110353061 Reviewed by Myles C. Maxfield. This was already done internally in ICU in rdar://107702106 This reflects changes published as GB-18030-2022 This was proposed as a change to the standard at whatwg/encoding#312 This fixes an assertion when running encoding tests on macOS Sonoma and iOS 17, and I added test coverage specific to the 18 changed code points. * LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-encoder-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/encoding/legacy-mb-schinese/gb18030/gb18030-encoder.html: * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/pal/text/EncodingTables.cpp: (PAL::gb18030): Canonical link: https://commits.webkit.org/264918@main
webkit-commit-queue
force-pushed
the
eng/Update-GB-18030-encoding-table
branch
from
dc7d29a
to
b7d4f07
Compare
|
Committed 264918@main (b7d4f07): https://commits.webkit.org/264918@main Reviewed commits have been landed. Closing PR #14716 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
|
Note: #15413 has a necessary fix after this. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 24, 2023
This CL imports WebKit/WebKit#14716. In case supporting GB18030-2022 causes the issues, it has been implemented behind the Gb18030_2022Enabled flag. Change-Id: Ie50d6b0c32fa18026c43414b3a8404556640b5d0 Bug: 1457267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4710388 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/main@{#1174127}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b7d4f07
dc7d29a
🛠 wincairo🧪 api-mac🛠 🧪 jsc🧪 mac-AS-debug-wk2🛠 tv-sim🛠 watch