Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cocoa] colorSpace values missing from videoTrack.configuration with MP4s missing explicit color information #14824

Merged
merged 1 commit into from
Jun 10, 2023
Merged

[Cocoa] colorSpace values missing from videoTrack.configuration with MP4s missing explicit color information #14824

merged 1 commit into from
Jun 10, 2023

Conversation

jernoble
Copy link
Contributor

@jernoble jernoble commented Jun 9, 2023 •
edited by webkit-early-warning-system

41652ca

[Cocoa] colorSpace values missing from videoTrack.configuration with MP4s missing explicit color information
https://bugs.webkit.org/show_bug.cgi?id=257911
rdar://110545901

Reviewed by Andy Estes.

Read the default colorspace values for a given codec and size from VideoToolbox.

* LayoutTests/media/track/video-track-configuration-mp4-default-colorspace-expected.txt: Added.
* LayoutTests/media/track/video-track-configuration-mp4-default-colorspace.html: Added.

Canonical link: https://commits.webkit.org/265053@main

f7606e4

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@jernoble jernoble self-assigned this Jun 9, 2023
@jernoble jernoble added the Media Bugs related to the HTML 5 Media elements. label Jun 9, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 1b61bb0)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac   🛠 wpe ⏳ 🛠 wincairo
  🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv   🧪 mac-AS-debug-wk2 ⏳ 🛠 jsc-armv7
⏳ 🛠 tv-sim   🧪 mac-wk2-stress ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch
⏳ 🛠 watch-sim

@jernoble jernoble force-pushed the eng/Cocoa-colorSpace-values-missing-from-videoTrack-configuration-with-MP4s-missing-explicit-color-information branch from 1b61bb0 to 4ca1074 Compare June 9, 2023 21:01
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 4ca1074)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
⏳ 🛠 watch
✅ 🛠 watch-sim

@jernoble jernoble force-pushed the eng/Cocoa-colorSpace-values-missing-from-videoTrack-configuration-with-MP4s-missing-explicit-color-information branch from 4ca1074 to 3607f37 Compare June 9, 2023 23:30
@jernoble jernoble requested a review from aestes June 9, 2023 23:30
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 3607f37)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
  🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim   🧪 mac-wk2-stress
⏳ 🛠 watch
⏳ 🛠 watch-sim

@jernoble jernoble force-pushed the eng/Cocoa-colorSpace-values-missing-from-videoTrack-configuration-with-MP4s-missing-explicit-color-information branch from 3607f37 to 383339e Compare June 9, 2023 23:34
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 383339e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 api-gtk
❌ 🛠 tv   🧪 mac-AS-debug-wk2
❌ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
  🛠 🧪 merge ❌ 🛠 watch
❌ 🛠 watch-sim

@jernoble jernoble requested a review from aestes June 9, 2023 23:34
@jernoble jernoble added the merge-queue Applied to send a pull request to merge-queue label Jun 9, 2023
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Jun 10, 2023
@jernoble jernoble removed the merging-blocked Applied to prevent a change from being merged label Jun 10, 2023
@jernoble jernoble force-pushed the eng/Cocoa-colorSpace-values-missing-from-videoTrack-configuration-with-MP4s-missing-explicit-color-information branch from 383339e to f7606e4 Compare June 10, 2023 04:05
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash f7606e4)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@jernoble jernoble added the merge-queue Applied to send a pull request to merge-queue label Jun 10, 2023
@jernoble
[Cocoa] colorSpace values missing from videoTrack.configuration with …
41652ca 
…MP4s missing explicit color information

https://bugs.webkit.org/show_bug.cgi?id=257911
rdar://110545901

Reviewed by Andy Estes.

Read the default colorspace values for a given codec and size from VideoToolbox.

* LayoutTests/media/track/video-track-configuration-mp4-default-colorspace-expected.txt: Added.
* LayoutTests/media/track/video-track-configuration-mp4-default-colorspace.html: Added.

Canonical link: https://commits.webkit.org/265053@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Cocoa-colorSpace-values-missing-from-videoTrack-configuration-with-MP4s-missing-explicit-color-information branch from f7606e4 to 41652ca Compare June 10, 2023 06:23
@webkit-commit-queue webkit-commit-queue merged commit 41652ca into WebKit:main Jun 10, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 265053@main (41652ca): https://commits.webkit.org/265053@main

Reviewed commits have been landed. Closing PR #14824 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 10, 2023
@jernoble jernoble deleted the eng/Cocoa-colorSpace-values-missing-from-videoTrack-configuration-with-MP4s-missing-explicit-color-information branch October 26, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aestes aestes aestes approved these changes

@jyavenard jyavenard Awaiting requested review from jyavenard

@eric-carlson eric-carlson Awaiting requested review from eric-carlson

Assignees

@jernoble jernoble

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
5 participants
@jernoble @webkit-early-warning-system @webkit-commit-queue @aestes @webkit-ews-buildbot