Upstream shareSheetUsesModalPresentationForWebView #14828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hortont424
added
the
WebKit Misc.
|
EWS run on previous version of this PR (hash 5eb02bb)
|
|
will get the header too |
hortont424
force-pushed
the
eng/Upstream-shareSheetUsesModalPresentationForWebView
branch
from
5eb02bb
to
9bbd677
Compare
|
EWS run on current version of this PR (hash 9bbd677)
|
pxlcoder
approved these changes
Jun 9, 2023
| @@ -333,7 +329,7 @@ - (void)presentWithShareDataArray:(NSArray *)sharingItems inRect:(std::optional< | |||
| }]; | |||
|
|
|||
| #if PLATFORM(VISION) | |||
There was a problem hiding this comment.
We don't actually need this conditional right?
There was a problem hiding this comment.
Though it will probably cause issues with current EWS if we don't replace with an SDK version check... so never mind.
hortont424
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=257913 rdar://110548897 Reviewed by Aditya Keerthi. * Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm: (-[WKShareSheet presentWithShareDataArray:inRect:]): Canonical link: https://commits.webkit.org/265040@main
webkit-commit-queue
force-pushed
the
eng/Upstream-shareSheetUsesModalPresentationForWebView
branch
from
9bbd677
to
cb63b1b
Compare
|
Committed 265040@main (cb63b1b): https://commits.webkit.org/265040@main Reviewed commits have been landed. Closing PR #14828 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cb63b1b
9bbd677
🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 gtk-wk2🧪 api-ios🧪 mac-wk2🧪 api-gtk🛠 tv🛠 tv-sim🛠 watch🛠 watch-sim