New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement font-language-override #14837
base: main
Are you sure you want to change the base?
Implement font-language-override #14837
Conversation
c351904
to
409efd5
Compare
EWS run on previous version of this PR (hash 409efd5) |
Is this a good idea? I've spoken in the CSSWG about how I think this property shouldn't exist, and authors should just use |
Hi @litherum, thanks for your interest in this WIP patch. I just aimed to see how I am aware of w3c/csswg-drafts#5484. My rationale and motivation for this feature are three.
We can continue our discussion in the ticket of the CSS WG. |
https://bugs.webkit.org/show_bug.cgi?id=150081 Reviewed by NOBODY (OOPS!). WIP. * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): * Source/WebCore/platform/graphics/FontCascadeDescription.cpp: * Source/WebCore/platform/graphics/FontCascadeDescription.h: (WebCore::FontCascadeDescription::initialLanguageOverride): * Source/WebCore/platform/graphics/FontDescription.cpp: (WebCore::FontDescription::setLanguageOverride): * Source/WebCore/platform/graphics/FontDescription.h: (WebCore::FontDescription::languageOverride const): * Source/WebCore/rendering/style/RenderStyle.h: * Source/WebCore/rendering/style/RenderStyleInlines.h: (WebCore::RenderStyle::fontLanguageOverride const): * Source/WebCore/style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyValueFontLanguageOverride):
409efd5
to
bf590eb
Compare
EWS run on current version of this PR (hash bf590eb) |
409efd5ab32743edb9eec26883621e3044f23486
bf590eb