Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Make DFG mayExit more precise #14857

Merged
merged 1 commit into from
Jun 12, 2023
Merged

[JSC] Make DFG mayExit more precise #14857

merged 1 commit into from
Jun 12, 2023

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Jun 12, 2023 •
edited by webkit-early-warning-system

ebf14eb

[JSC] Make DFG mayExit more precise
https://bugs.webkit.org/show_bug.cgi?id=257951
rdar://110628197

Reviewed by Justin Michaud.

Making this precise is particularly important for numerical compute-intensive functions,
so that we can avoid unnecessary OSR exit-driven MovHint, which keeps some of unnecessary
arithmetic ops alive.

* Source/JavaScriptCore/dfg/DFGMayExit.cpp:

Canonical link: https://commits.webkit.org/265077@main

927ab21

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@Constellation Constellation requested a review from a team as a code owner June 12, 2023 07:57
@Constellation Constellation self-assigned this Jun 12, 2023
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jun 12, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 927ab21)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 12, 2023
@Constellation Constellation removed the merging-blocked Applied to prevent a change from being merged label Jun 12, 2023
justinmichaud
justinmichaud approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@justinmichaud justinmichaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 12, 2023
@Constellation
[JSC] Make DFG mayExit more precise
ebf14eb 
https://bugs.webkit.org/show_bug.cgi?id=257951
rdar://110628197

Reviewed by Justin Michaud.

Making this precise is particularly important for numerical compute-intensive functions,
so that we can avoid unnecessary OSR exit-driven MovHint, which keeps some of unnecessary
arithmetic ops alive.

* Source/JavaScriptCore/dfg/DFGMayExit.cpp:

Canonical link: https://commits.webkit.org/265077@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Make-DFG-mayExit-more-precise branch from 927ab21 to ebf14eb Compare June 12, 2023 18:34
@webkit-commit-queue
Copy link
Collaborator

Committed 265077@main (ebf14eb): https://commits.webkit.org/265077@main

Reviewed commits have been landed. Closing PR #14857 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ebf14eb into WebKit:main Jun 12, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 12, 2023
@Constellation Constellation deleted the eng/JSC-Make-DFG-mayExit-more-precise branch June 12, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmichaud justinmichaud justinmichaud approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
5 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @justinmichaud @webkit-ews-buildbot