Only set launch sandbox state variable once #14881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvollan
added
the
WebKit Misc.
|
EWS run on previous version of this PR (hash 01c1405)
|
cdumez
requested changes
Jun 12, 2023
| @@ -484,8 +484,11 @@ Ref<WebPage> WebPage::create(PageIdentifier pageID, WebPageCreationParameters&& | |||
| WebProcess::singleton().injectedBundle()->didCreatePage(page.ptr()); | |||
|
|
|||
| #if HAVE(SANDBOX_STATE_FLAGS) | |||
| auto auditToken = WebProcess::singleton().auditTokenForSelf(); | |||
| sandbox_enable_state_flag("WebContentProcessLaunched", *auditToken); | |||
| static dispatch_once_t onceToken; | |||
There was a problem hiding this comment.
We should use a global static boolean. We don't need a dispatch_once because we don't need locking because there is only a single thread involved.
There was a problem hiding this comment.
Ah, good point, will fix!
Thanks for reviewing!
pvollan
force-pushed
the
eng/Only-set-launch-sandbox-state-variable-once
branch
from
01c1405
to
82f0dcf
Compare
|
EWS run on current version of this PR (hash 82f0dcf)
|
cdumez
approved these changes
Jun 12, 2023
https://bugs.webkit.org/show_bug.cgi?id=257974 rdar://110660033 Reviewed by Chris Dumez. Only set launch sandbox state variable once to improve performance. * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::create): Canonical link: https://commits.webkit.org/265088@main
webkit-commit-queue
force-pushed
the
eng/Only-set-launch-sandbox-state-variable-once
branch
from
82f0dcf
to
b4b2f80
Compare
|
Committed 265088@main (b4b2f80): https://commits.webkit.org/265088@main Reviewed commits have been landed. Closing PR #14881 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b4b2f80
82f0dcf
🛠 wincairo🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk2🧪 mac-AS-debug-wk2🛠 tv-sim🛠 watch