Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary call to sandbox_enable_state_flag #14889

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Jun 12, 2023

e2a7a06

Avoid unnecessary call to sandbox_enable_state_flag
https://bugs.webkit.org/show_bug.cgi?id=257981
rdar://110667778

Reviewed by Chris Dumez.

Calling sandbox_enable_state_flag with the variable BlockIOKitInWebContentSandbox is only needed
when WEBCONTENT_GPU_SANDBOX_EXTENSIONS_BLOCKING is not enabled. This patch also removes an
obsolete sandbox rule.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_appHighlightsVisible):

Canonical link: https://commits.webkit.org/265122@main

f1c6523

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv ❌ πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@pvollan pvollan self-assigned this Jun 12, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jun 12, 2023
@pvollan pvollan requested a review from szewai June 12, 2023 22:09
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 13, 2023
@pvollan
Copy link
Contributor Author

pvollan commented Jun 13, 2023

Thanks for reviewing!

@pvollan pvollan added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jun 13, 2023
https://bugs.webkit.org/show_bug.cgi?id=257981
rdar://110667778

Reviewed by Chris Dumez.

Calling sandbox_enable_state_flag with the variable BlockIOKitInWebContentSandbox is only needed
when WEBCONTENT_GPU_SANDBOX_EXTENSIONS_BLOCKING is not enabled. This patch also removes an
obsolete sandbox rule.

* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_appHighlightsVisible):

Canonical link: https://commits.webkit.org/265122@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Avoid-unnecessary-call-to-sandbox_enable_state_flag branch from f1c6523 to e2a7a06 Compare June 13, 2023 16:02
@webkit-commit-queue
Copy link
Collaborator

Committed 265122@main (e2a7a06): https://commits.webkit.org/265122@main

Reviewed commits have been landed. Closing PR #14889 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e2a7a06 into WebKit:main Jun 13, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
5 participants