Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git-webkit] Prompt user for bugzilla credentials during setup #149

Closed

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Feb 15, 2022

1957c74

[git-webkit] Prompt user for bugzilla credentials during setup
https://bugs.webkit.org/show_bug.cgi?id=236659
<rdar://problem/88980650 >

Reviewed by NOBODY (OOPS!).

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py:
(credentials): Store credentials under "bugs.webkit.org" instead of "https://bugs.webkit.org";
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.git): Prompt user for bugzilla credentials.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:

@JonWBedard
Copy link
Member Author

The "how" of this patch is pretty straight forward, but the consequences might be somewhat controversial.

  • This will block setup on having a valid bugzilla account
  • Moving from https:// to in keychain aligns with what Safari does, but will break folks who have already run git-webkit setup

@aj062
Copy link
Member

aj062 commented Feb 15, 2022

  • This will block setup on having a valid bugzilla account

You can consider making this optional, where user has option to skip this step. If skipped git-webkit wouldn't comment on the bug automatically, but rest everything will keep working.

@aproskuryakov
Copy link
Contributor

  • This will block setup on having a valid bugzilla account

This does seem very controversial indeed. Mostly because it's something that we'd ask new contributors to do preemptively, before they had a chance to hack on the code and decide if they have something to submit.

Existing contributors would almost certainly already have the credentials in Mac keychain, so we don't need to be asked again.

@JonWBedard
Copy link
Member Author

  • This will block setup on having a valid bugzilla account

This does seem very controversial indeed. Mostly because it's something that we'd ask new contributors to do preemptively, before they had a chance to hack on the code and decide if they have something to submit.

Existing contributors would almost certainly already have the credentials in Mac keychain, so we don't need to be asked again.

webkitcorepy.credentials is decently smart, the reason I'm making the shift from https://<hostname> to <hostname> in this PR is because we are checking the existing keychain values, if we have valid bugzilla credentials, folks won't be prompted

@JonWBedard
Copy link
Member Author

Updated PR lets folks cntrl-C out of providing bugzilla credentials.

@JonWBedard JonWBedard force-pushed the eng/git-webkit-setup-bugzilla branch 5 times, most recently from e5554a0 to f939167 Compare February 18, 2022 21:05
@JonWBedard JonWBedard force-pushed the eng/git-webkit-setup-bugzilla branch 2 times, most recently from c9229be to 87ca17c Compare February 28, 2022 20:36
@JonWBedard JonWBedard force-pushed the eng/git-webkit-setup-bugzilla branch from 87ca17c to 351fba9 Compare March 7, 2022 18:51
@JonWBedard JonWBedard changed the title [git-webkit] Prompt user for bugzilla credentials during setup [ Mar 7, 2022
@JonWBedard JonWBedard force-pushed the eng/git-webkit-setup-bugzilla branch from b3f509c to 351fba9 Compare March 7, 2022 19:06
@JonWBedard JonWBedard changed the title [ [git-webkit] Prompt user for bugzilla credentials during setup Mar 7, 2022
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Mar 29, 2022
@JonWBedard JonWBedard force-pushed the eng/git-webkit-setup-bugzilla branch from 351fba9 to 47b05b2 Compare March 29, 2022 21:16
@JonWBedard JonWBedard added the merge-queue Applied to send a pull request to merge-queue label Mar 29, 2022
@JonWBedard JonWBedard force-pushed the eng/git-webkit-setup-bugzilla branch from 350bc78 to 436201a Compare March 29, 2022 22:12
@JonWBedard JonWBedard added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Mar 29, 2022
@JonWBedard JonWBedard force-pushed the eng/git-webkit-setup-bugzilla branch from b24ebd9 to 37b7da9 Compare March 29, 2022 22:58
@JonWBedard JonWBedard added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Mar 29, 2022
https://bugs.webkit.org/show_bug.cgi?id=236659
<rdar://problem/88980650>

Reviewed by NOBODY (OOPS!).

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py:
(credentials): Store credentials under "bugs.webkit.org" instead of "https://bugs.webkit.org"
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
(Setup.git): Prompt user for bugzilla credentials.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:
@JonWBedard JonWBedard force-pushed the eng/git-webkit-setup-bugzilla branch from 9e2cb83 to 1957c74 Compare March 29, 2022 23:06
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Mar 30, 2022
@JonWBedard JonWBedard removed merging-blocked Applied to prevent a change from being merged merge-queue Applied to send a pull request to merge-queue labels Mar 30, 2022
@JonWBedard JonWBedard closed this Mar 31, 2022
@JonWBedard JonWBedard deleted the eng/git-webkit-setup-bugzilla branch March 31, 2022 20:37
@JonWBedard JonWBedard restored the eng/git-webkit-setup-bugzilla branch April 4, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants