New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[git-webkit] Prompt user for bugzilla credentials during setup #149
Conversation
The "how" of this patch is pretty straight forward, but the consequences might be somewhat controversial.
|
You can consider making this optional, where user has option to skip this step. If skipped git-webkit wouldn't comment on the bug automatically, but rest everything will keep working. |
This does seem very controversial indeed. Mostly because it's something that we'd ask new contributors to do preemptively, before they had a chance to hack on the code and decide if they have something to submit. Existing contributors would almost certainly already have the credentials in Mac keychain, so we don't need to be asked again. |
|
44d7419
to
feb90d7
Compare
Updated PR lets folks cntrl-C out of providing bugzilla credentials. |
e5554a0
to
f939167
Compare
c9229be
to
87ca17c
Compare
87ca17c
to
351fba9
Compare
b3f509c
to
351fba9
Compare
351fba9
to
47b05b2
Compare
47b05b2
to
350bc78
Compare
350bc78
to
436201a
Compare
436201a
to
b24ebd9
Compare
b24ebd9
to
37b7da9
Compare
37b7da9
to
9e2cb83
Compare
https://bugs.webkit.org/show_bug.cgi?id=236659 <rdar://problem/88980650> Reviewed by NOBODY (OOPS!). * Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py: (credentials): Store credentials under "bugs.webkit.org" instead of "https://bugs.webkit.org" * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py: (Setup.git): Prompt user for bugzilla credentials. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py:
9e2cb83
to
1957c74
Compare
1957c74