Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Use int32 serialization for double stringifying in JSStringJoiner #14900

Merged
merged 1 commit into from
Jun 13, 2023
Merged

[JSC] Use int32 serialization for double stringifying in JSStringJoiner #14900

merged 1 commit into from
Jun 13, 2023

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Jun 13, 2023 •
edited by webkit-early-warning-system

ad54954

[JSC] Use int32 serialization for double stringifying in JSStringJoiner
https://bugs.webkit.org/show_bug.cgi?id=257995
rdar://110682175

Reviewed by Mark Lam.

Add int32 fast path for double stringifying in JSStringJoiner.

* Source/JavaScriptCore/runtime/ArrayPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/JSStringJoiner.h:
(JSC::JSStringJoiner::appendNumber):

Canonical link: https://commits.webkit.org/265102@main

f95ad74

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim   🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@Constellation Constellation requested a review from a team as a code owner June 13, 2023 02:38
@Constellation Constellation self-assigned this Jun 13, 2023
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jun 13, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 36f14f3)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ⏳ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1 ⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2 ⏳ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ⏳ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim   🧪 jsc-mips-tests

@Constellation Constellation force-pushed the eng/JSC-Use-int32-serialization-for-double-stringifying-in-JSStringJoiner branch from 36f14f3 to f95ad74 Compare June 13, 2023 02:43
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash f95ad74)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac   🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
  🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv   🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim   🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

MenloDorian
MenloDorian approved these changes Jun 13, 2023
View reviewed changes
Copy link

@MenloDorian MenloDorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 13, 2023
@Constellation
[JSC] Use int32 serialization for double stringifying in JSStringJoiner
ad54954 
https://bugs.webkit.org/show_bug.cgi?id=257995
rdar://110682175

Reviewed by Mark Lam.

Add int32 fast path for double stringifying in JSStringJoiner.

* Source/JavaScriptCore/runtime/ArrayPrototype.cpp:
(JSC::JSC_DEFINE_HOST_FUNCTION):
* Source/JavaScriptCore/runtime/JSStringJoiner.h:
(JSC::JSStringJoiner::appendNumber):

Canonical link: https://commits.webkit.org/265102@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Use-int32-serialization-for-double-stringifying-in-JSStringJoiner branch from f95ad74 to ad54954 Compare June 13, 2023 04:40
@webkit-commit-queue
Copy link
Collaborator

Committed 265102@main (ad54954): https://commits.webkit.org/265102@main

Reviewed commits have been landed. Closing PR #14900 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ad54954 into WebKit:main Jun 13, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MenloDorian MenloDorian MenloDorian approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @MenloDorian