Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WGSL] Add support for call expressions with packed types #14926

Conversation

tadeuzagallo
Copy link
Member

@tadeuzagallo tadeuzagallo commented Jun 13, 2023

e553d77

[WGSL] Add support for call expressions with packed types
https://bugs.webkit.org/show_bug.cgi?id=258029
rdar://110712618

Reviewed by Mike Wyrzykowski.

Expand the global variable rewriter to support call expressions with packed values.
Calls work by unpacking all arguments, and their result is always unpacked.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::pack):
(WGSL::RewriteGlobalVariables::getPacking):
* Source/WebGPU/WGSL/tests/valid/packing.wgsl:

Canonical link: https://commits.webkit.org/265151@main

be5eef4

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@tadeuzagallo tadeuzagallo self-assigned this Jun 13, 2023
@tadeuzagallo tadeuzagallo added the WebGPU For bugs in WebGPU label Jun 13, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 13, 2023
Copy link
Contributor

@mwyrzykowski mwyrzykowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures appear unrelated

@mwyrzykowski mwyrzykowski removed the merging-blocked Applied to prevent a change from being merged label Jun 14, 2023
@tadeuzagallo tadeuzagallo added the merge-queue Applied to send a pull request to merge-queue label Jun 14, 2023
https://bugs.webkit.org/show_bug.cgi?id=258029
rdar://110712618

Reviewed by Mike Wyrzykowski.

Expand the global variable rewriter to support call expressions with packed values.
Calls work by unpacking all arguments, and their result is always unpacked.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::pack):
(WGSL::RewriteGlobalVariables::getPacking):
* Source/WebGPU/WGSL/tests/valid/packing.wgsl:

Canonical link: https://commits.webkit.org/265151@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WGSL-Add-support-for-call-expressions-with-packed-types branch from be5eef4 to e553d77 Compare June 14, 2023 10:56
@webkit-commit-queue
Copy link
Collaborator

Committed 265151@main (e553d77): https://commits.webkit.org/265151@main

Reviewed commits have been landed. Closing PR #14926 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 14, 2023
@webkit-commit-queue webkit-commit-queue merged commit e553d77 into WebKit:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebGPU For bugs in WebGPU
Projects
None yet
5 participants