Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New fast/dom/Window/setInterval-setTimeout-zero-ordering.html test is flaky #14932

Merged
merged 1 commit into from
Jun 14, 2023
Merged

New fast/dom/Window/setInterval-setTimeout-zero-ordering.html test is flaky #14932

merged 1 commit into from
Jun 14, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Jun 13, 2023 •
edited by webkit-early-warning-system

cae0100

New fast/dom/Window/setInterval-setTimeout-zero-ordering.html test is flaky
https://bugs.webkit.org/show_bug.cgi?id=258039

Reviewed by Brent Fulgham.

Separate the testing of the zero delay timers with the 1ms delay timers
to avoid flakiness.

* LayoutTests/fast/dom/Window/setInterval-setTimeout-zero-ordering.html:

Canonical link: https://commits.webkit.org/265165@main

37b8154

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez requested a review from rniwa as a code owner June 13, 2023 19:29
@cdumez cdumez self-assigned this Jun 13, 2023
@cdumez cdumez added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jun 13, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 37b8154)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 14, 2023
brentfulgham
brentfulgham approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. r=me

@cdumez cdumez added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jun 14, 2023
@cdumez
New fast/dom/Window/setInterval-setTimeout-zero-ordering.html test is…
cae0100 
… flaky

https://bugs.webkit.org/show_bug.cgi?id=258039

Reviewed by Brent Fulgham.

Separate the testing of the zero delay timers with the 1ms delay timers
to avoid flakiness.

* LayoutTests/fast/dom/Window/setInterval-setTimeout-zero-ordering.html:

Canonical link: https://commits.webkit.org/265165@main
@webkit-commit-queue
Copy link
Collaborator

Committed 265165@main (cae0100): https://commits.webkit.org/265165@main

Reviewed commits have been landed. Closing PR #14932 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit cae0100 into WebKit:main Jun 14, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@rniwa rniwa Awaiting requested review from rniwa rniwa is a code owner

@achristensen07 achristensen07 Awaiting requested review from achristensen07

@youennf youennf Awaiting requested review from youennf

Assignees

@cdumez cdumez

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
5 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @brentfulgham @webkit-ews-buildbot