Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The HTMLPreloadScanner ignores the referrerpolicy attribute for img elements #15022

Merged
merged 1 commit into from
Jun 16, 2023
Merged

The HTMLPreloadScanner ignores the referrerpolicy attribute for img elements #15022

merged 1 commit into from
Jun 16, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Jun 15, 2023 •
edited by webkit-early-warning-system

2835282

The HTMLPreloadScanner ignores the referrerpolicy attribute for img elements
https://bugs.webkit.org/show_bug.cgi?id=258164

Reviewed by Ryosuke Niwa.

Parse the referrerpolicy attribute for img tags inside the HTMLPreloadScanner,
like we already do for some other tags.

* LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/img-src-referrerpolicy-no-referrer.tentative.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/img-src-referrerpolicy-no-referrer.tentative-expected.txt:
* Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

Canonical link: https://commits.webkit.org/265223@main

62deb6c

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Jun 15, 2023
@cdumez cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jun 15, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 62deb6c)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez marked this pull request as ready for review June 15, 2023 23:40
@cdumez cdumez requested a review from rniwa as a code owner June 15, 2023 23:40
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Jun 16, 2023
@cdumez
The HTMLPreloadScanner ignores the referrerpolicy attribute for img e…
2835282 
…lements

https://bugs.webkit.org/show_bug.cgi?id=258164

Reviewed by Ryosuke Niwa.

Parse the referrerpolicy attribute for img tags inside the HTMLPreloadScanner,
like we already do for some other tags.

* LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/document-write/img-src-referrerpolicy-no-referrer.tentative.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/syntax/speculative-parsing/generated/page-load/img-src-referrerpolicy-no-referrer.tentative-expected.txt:
* Source/WebCore/html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

Canonical link: https://commits.webkit.org/265223@main
@webkit-commit-queue webkit-commit-queue force-pushed the 258164_preload_scanner_img_referrer_policy branch from 62deb6c to 2835282 Compare June 16, 2023 02:24
@webkit-commit-queue
Copy link
Collaborator

Committed 265223@main (2835282): https://commits.webkit.org/265223@main

Reviewed commits have been landed. Closing PR #15022 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2835282 into WebKit:main Jun 16, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa rniwa approved these changes

@achristensen07 achristensen07 Awaiting requested review from achristensen07

@youennf youennf Awaiting requested review from youennf

@anttijk anttijk Awaiting requested review from anttijk

@darinadler darinadler Awaiting requested review from darinadler

Assignees

@cdumez cdumez

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @rniwa