Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Fix for RealitySystemSupport #15033

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Build Fix for RealitySystemSupport #15033

merged 1 commit into from
Jun 16, 2023

Conversation

megangardner
Copy link
Contributor

@megangardner megangardner commented Jun 16, 2023 •
edited by webkit-early-warning-system

@megangardner megangardner self-assigned this Jun 16, 2023
@megangardner megangardner added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jun 16, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 824e6ac)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@megangardner megangardner added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 16, 2023
@webkit-commit-queue
Copy link
Collaborator

No reviewer information in commit message, blocking PR #15033

@webkit-commit-queue webkit-commit-queue added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jun 16, 2023
@megangardner megangardner removed the merging-blocked Applied to prevent a change from being merged label Jun 16, 2023
@megangardner megangardner force-pushed the eng/Build-Fix-for-RealitySystemSupport branch from 824e6ac to d6e6ff5 Compare June 16, 2023 17:54
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash d6e6ff5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2   🧪 api-gtk
❌ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@megangardner megangardner added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 16, 2023
@megangardner
Build Fix for RealitySystemSupport
a1509bd 
https://bugs.webkit.org/show_bug.cgi?id=258182
rdar://110872747

Unreviewed Build Fix.

* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeInteractionRegionLayers.mm:

Canonical link: https://commits.webkit.org/265253@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Build-Fix-for-RealitySystemSupport branch from d6e6ff5 to a1509bd Compare June 16, 2023 18:57
@webkit-commit-queue
Copy link
Collaborator

Committed 265253@main (a1509bd): https://commits.webkit.org/265253@main

Reviewed commits have been landed. Closing PR #15033 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a1509bd into WebKit:main Jun 16, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m left review comments

@pxlcoder pxlcoder pxlcoder left review comments

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@megangardner megangardner

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
5 participants
@megangardner @webkit-early-warning-system @webkit-commit-queue @nt1m @pxlcoder