Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate WebPageCreationParameters IPC serializer / deserializer #15064

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Generate WebPageCreationParameters IPC serializer / deserializer #15064

merged 1 commit into from
Jun 17, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Jun 17, 2023 •
edited by webkit-early-warning-system

0859d2b

Generate WebPageCreationParameters IPC serializer / deserializer
https://bugs.webkit.org/show_bug.cgi?id=258230
rdar://108613404

Reviewed by Darin Adler.

Auto-generate the WebPageCreationParameters IPC serializer / deserializer.
We see crashes in the wild when decoding the CreateWebPage IPC message and
this may help.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/WebPageCreationParameters.cpp: Removed.
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/Shared/WebPageCreationParameters.serialization.in: Added.
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/265273@main

1d17abb

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Jun 17, 2023
@cdumez cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label Jun 17, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash cdb3d81)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez changed the title Generate WebPageCreationPrameters IPC serializer / deserializer Generate WebPageCreationParameters IPC serializer / deserializer Jun 17, 2023
@cdumez cdumez force-pushed the WebPageCreationParameter_generated_serializers branch from cdb3d81 to cf17f00 Compare June 17, 2023 04:29
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash cf17f00)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

darinadler
darinadler approved these changes Jun 17, 2023
View reviewed changes
Source/WebKit/DerivedSources.make Outdated Show resolved Hide resolved
@cdumez cdumez force-pushed the WebPageCreationParameter_generated_serializers branch from cf17f00 to 1d17abb Compare June 17, 2023 05:11
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 1d17abb)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 17, 2023
@cdumez cdumez added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jun 17, 2023
@cdumez
Generate WebPageCreationParameters IPC serializer / deserializer
0859d2b 
https://bugs.webkit.org/show_bug.cgi?id=258230
rdar://108613404

Reviewed by Darin Adler.

Auto-generate the WebPageCreationParameters IPC serializer / deserializer.
We see crashes in the wild when decoding the CreateWebPage IPC message and
this may help.

* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/WebPageCreationParameters.cpp: Removed.
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/Shared/WebPageCreationParameters.serialization.in: Added.
* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/265273@main
@webkit-commit-queue
Copy link
Collaborator

Committed 265273@main (0859d2b): https://commits.webkit.org/265273@main

Reviewed commits have been landed. Closing PR #15064 and removing active labels.

@webkit-commit-queue webkit-commit-queue force-pushed the WebPageCreationParameter_generated_serializers branch from 1d17abb to 0859d2b Compare June 17, 2023 16:49
@webkit-commit-queue webkit-commit-queue merged commit 0859d2b into WebKit:main Jun 17, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@achristensen07 achristensen07 Awaiting requested review from achristensen07

Assignees

@cdumez cdumez

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
5 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler @webkit-ews-buildbot