Begin implementing cross-site window.open in a new process #15065

achristensen07 · 2023-06-17T04:25:22Z

`9bcdeaa`

Begin implementing cross-site window.open in a new process
https://bugs.webkit.org/show_bug.cgi?id=258231
rdar://110931870

Reviewed by Chris Dumez.

This takes some ideas from #10169
and some of Pascoe's more recent work, rebases on top of significant site isolation
architecture changes since then, and cleans them up with a slightly expanded test.

The back/forward navigations in the existing API test ProcessSwap.SameSiteWindowWithOpenerNavigateToFile
cover some transitions that have not been implemented yet, so I temporarily disable the test until
those transitions are implemented.  This greatly simplified this PR and allowed me to break the development
into more manageable pieces, each of which can be merged with test coverage showing progress, and each
of which is covered by a currently off-by-default feature flag.

Two important transitions need to happen when implementing window.open in a new process.  The first is
when the ProvisionalPageProxy is constructed.  The main frame already exists in the opener process
(and it is showing about:blank unless it has had a same-site URL loaded in it) but when we make a frame
in the new process we need that main frame to have an opener frame as a RemoteFrame, so we need to have
the opener inject a WebPage with a remote frame tree into the process first.  We do this by creating
a RemotePageProxy owned by the opener in the process we are provisionally navigating to.

The second transition happens when we begin receiving HTTP body for the provisional navigation and the
navigation commits.  In ProvisionalPageProxy::didCommitLoadForFrame we need to tell the frames of the
opened page in the opener process to transition to remote frames (which are still needed to be the targets
of operations like postMessage) and we do this by sending the WebPage::DidCommitLoadInAnotherProcess message.
We then create a RemotePageProxy for those remote frames to communicate with and set up message receivers.
Because the process already has a WebPage and frame tree in it, we separate the new function
RemotePageProxy::injectPageIntoNewProcess from what used to be done in each RemotePageProxy constructor.
We need to prevent this WebPage from being closed or suspended, which we do in the changes in WebPageProxy.cpp.

Since each Page can have 0 or 1 openers, we add a new member to WebPageProxy::Internals named
remotePageProxyInOpenerProcess to retain ownership of the RemotePageProxy communicating with frames
in that process.  Each Page can have an unlimited number of Pages it has opened, so the symmetric other
side of that member is a set of openedRemotePageProxies.

A few other small changes are needed to hook up remote openers, and make it possible for a main frame to
transition between local and remote, which requires changing the main frame of a WebCore::Page.

* Source/WebCore/bindings/js/WindowProxy.cpp:
(WebCore::WindowProxy::replaceFrame):
* Source/WebCore/bindings/js/WindowProxy.h:
* Source/WebCore/page/Frame.cpp:
(WebCore::Frame::resetWindowProxy):
(WebCore::Frame::takeWindowProxy):
* Source/WebCore/page/Frame.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::setMainFrame):
* Source/WebCore/page/Page.h:
* Source/WebCore/page/RemoteFrame.cpp:
(WebCore::RemoteFrame::createSubframeWithContentsInAnotherProcess):
* Source/WebCore/page/RemoteFrame.h:
* Source/WebKit/Shared/FrameInfoData.h:
* Source/WebKit/Shared/FrameInfoData.serialization.in:
* Source/WebKit/Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/UIProcess/API/APIFrameInfo.h:
* Source/WebKit/UIProcess/API/APIFrameTreeNode.h:
* Source/WebKit/UIProcess/API/Cocoa/WKFrameInfo.mm:
(-[WKFrameInfo _processIdentifier]):
* Source/WebKit/UIProcess/API/Cocoa/_WKFrameTreeNode.mm:
(-[_WKFrameTreeNode _processIdentifier]):
* Source/WebKit/UIProcess/FrameLoadState.cpp:
(WebKit::FrameLoadState::didStartProvisionalLoad):
* Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp:
(WebKit::ProvisionalFrameProxy::ProvisionalFrameProxy):
* Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
(WebKit::ProvisionalPageProxy::initializeWebPage):
(WebKit::ProvisionalPageProxy::didCreateMainFrame):
(WebKit::ProvisionalPageProxy::didCommitLoadForFrame):
* Source/WebKit/UIProcess/RemotePageProxy.cpp:
(WebKit::RemotePageProxy::RemotePageProxy):
(WebKit::RemotePageProxy::injectPageIntoNewProcess):
(WebKit::RemotePageProxy::~RemotePageProxy):
* Source/WebKit/UIProcess/RemotePageProxy.h:
(WebKit::RemotePageProxy::pageID const):
(WebKit::RemotePageProxy::domain const):
* Source/WebKit/UIProcess/WebFrameProxy.h:
(WebKit::WebFrameProxy::setProcess):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::suspendCurrentPageIfPossible):
(WebKit::WebPageProxy::commitProvisionalPage):
(WebKit::WebPageProxy::shouldClosePreviousPage):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::getAllFrameTrees):
(WebKit::WebPageProxy::createNewPage):
(WebKit::WebPageProxy::addRemotePageProxy):
(WebKit::WebPageProxy::setRemotePageProxyInOpenerProcess):
(WebKit::WebPageProxy::addOpenedRemotePageProxy):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:
(WebKit::WebRemoteFrameClient::changeLocation):
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::info const):
(WebKit::WebFrame::didCommitLoadInAnotherProcess):
(WebKit::WebFrame::transitionToLocal):
* Source/WebKit/WebProcess/WebPage/WebFrame.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::m_appHighlightsVisible):
(WebKit::WebPage::didCommitLoadInAnotherProcess):
(WebKit::WebPage::transitionFrameToLocal):
(WebKit::WebPage::transitionFrameToLocalAndLoadRequest): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/265321@main

f39ee89

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-06-17T04:25:33Z

EWS run on previous version of this PR (hash 4af069d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-06-17T07:10:58Z

EWS run on previous version of this PR (hash 25cd8f2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-06-17T21:18:20Z

EWS run on previous version of this PR (hash 928eba2)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
❌ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-06-17T22:49:25Z

EWS run on previous version of this PR (hash 61f5b0d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	~~🧪 api-gtk~~
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-06-17T23:44:06Z

EWS run on previous version of this PR (hash cfd18a6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

cdumez · 2023-06-18T00:09:59Z

Source/WebCore/page/Frame.cpp

@@ -104,4 +105,12 @@ void Frame::disconnectOwnerElement()
        document->frameWasDisconnectedFromOwner();
 }

+void Frame::takeWindowProxy(Frame& frame)


I find the naming slightly confusing. Maybe it should be takeWindowProxyFrom().

cdumez · 2023-06-18T00:11:36Z

Source/WebKit/UIProcess/FrameLoadState.cpp

@@ -46,7 +46,7 @@ void FrameLoadState::removeObserver(Observer& observer)

 void FrameLoadState::didStartProvisionalLoad(const URL& url)
 {
-    ASSERT(m_provisionalURL.isEmpty());
+    ASSERT(m_provisionalURL.isEmpty() || m_provisionalURL == url);


Seems like we may be papering over a real issue here? We don't want didStartProvisionalLoad to get called several times for the same load. This would be observable by the client app too.

I'll look closer. You're probably right

cdumez · 2023-06-18T00:19:15Z

Source/WebKit/UIProcess/WebPageProxyInternals.h

@@ -215,6 +215,8 @@ struct WebPageProxy::Internals final : WebPopupMenuProxy::Client
    PageAllowedToRunInTheBackgroundCounter::Token pageAllowedToRunInTheBackgroundToken;

    HashMap<WebCore::RegistrableDomain, WeakPtr<RemotePageProxy>> domainToRemotePageProxyMap;
+    RefPtr<RemotePageProxy> remotePageProxyInOpenerProcess;
+    HashSet<Ref<RemotePageProxy>> openedRemotePageProxies;


seems like we're leaking these objects here?

There's a FIXME comment by WebPageProxy::addOpenedRemotePageProxy

cdumez · 2023-06-18T00:21:49Z

Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm

@@ -1390,7 +1390,8 @@ static void enableWindowOpenPSON(WKWebViewConfiguration *configuration)
    }
 }

-TEST(ProcessSwap, CrossSiteWindowOpenWithOpener)
+// FIXME: Get this working.


Doesn't seem OK to regress pre-existing PSON API tests with new feature.

Why is there even a behavior change here? Isn't the new behavior gated by a feature flag?

These two tests are the two existing tests that enable the ProcessSwapOnCrossSiteWindowOpenEnabled feature. That's why they are affected.

Oh, I see. No concern then.

cdumez · 2023-06-18T00:21:56Z

Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm

@@ -7178,7 +7179,8 @@ static bool hasOverlay(CALayer *layer)

 static const char* openedPage = "Hello World";

-TEST(ProcessSwap, SameSiteWindowWithOpenerNavigateToFile)
+// FIXME: Get this working.


Doesn't seem OK to regress pre-existing PSON API tests with new feature.

cdumez

LGTM though it'd be nice to fix the duplicate calls to didStartProvisionalLoad.

webkit-early-warning-system · 2023-06-20T02:04:48Z

EWS run on current version of this PR (hash f39ee89)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=258231 rdar://110931870 Reviewed by Chris Dumez. This takes some ideas from WebKit#10169 and some of Pascoe's more recent work, rebases on top of significant site isolation architecture changes since then, and cleans them up with a slightly expanded test. The back/forward navigations in the existing API test ProcessSwap.SameSiteWindowWithOpenerNavigateToFile cover some transitions that have not been implemented yet, so I temporarily disable the test until those transitions are implemented. This greatly simplified this PR and allowed me to break the development into more manageable pieces, each of which can be merged with test coverage showing progress, and each of which is covered by a currently off-by-default feature flag. Two important transitions need to happen when implementing window.open in a new process. The first is when the ProvisionalPageProxy is constructed. The main frame already exists in the opener process (and it is showing about:blank unless it has had a same-site URL loaded in it) but when we make a frame in the new process we need that main frame to have an opener frame as a RemoteFrame, so we need to have the opener inject a WebPage with a remote frame tree into the process first. We do this by creating a RemotePageProxy owned by the opener in the process we are provisionally navigating to. The second transition happens when we begin receiving HTTP body for the provisional navigation and the navigation commits. In ProvisionalPageProxy::didCommitLoadForFrame we need to tell the frames of the opened page in the opener process to transition to remote frames (which are still needed to be the targets of operations like postMessage) and we do this by sending the WebPage::DidCommitLoadInAnotherProcess message. We then create a RemotePageProxy for those remote frames to communicate with and set up message receivers. Because the process already has a WebPage and frame tree in it, we separate the new function RemotePageProxy::injectPageIntoNewProcess from what used to be done in each RemotePageProxy constructor. We need to prevent this WebPage from being closed or suspended, which we do in the changes in WebPageProxy.cpp. Since each Page can have 0 or 1 openers, we add a new member to WebPageProxy::Internals named remotePageProxyInOpenerProcess to retain ownership of the RemotePageProxy communicating with frames in that process. Each Page can have an unlimited number of Pages it has opened, so the symmetric other side of that member is a set of openedRemotePageProxies. A few other small changes are needed to hook up remote openers, and make it possible for a main frame to transition between local and remote, which requires changing the main frame of a WebCore::Page. * Source/WebCore/bindings/js/WindowProxy.cpp: (WebCore::WindowProxy::replaceFrame): * Source/WebCore/bindings/js/WindowProxy.h: * Source/WebCore/page/Frame.cpp: (WebCore::Frame::resetWindowProxy): (WebCore::Frame::takeWindowProxy): * Source/WebCore/page/Frame.h: * Source/WebCore/page/Page.cpp: (WebCore::Page::setMainFrame): * Source/WebCore/page/Page.h: * Source/WebCore/page/RemoteFrame.cpp: (WebCore::RemoteFrame::createSubframeWithContentsInAnotherProcess): * Source/WebCore/page/RemoteFrame.h: * Source/WebKit/Shared/FrameInfoData.h: * Source/WebKit/Shared/FrameInfoData.serialization.in: * Source/WebKit/Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode): * Source/WebKit/Shared/WebPageCreationParameters.h: * Source/WebKit/UIProcess/API/APIFrameInfo.h: * Source/WebKit/UIProcess/API/APIFrameTreeNode.h: * Source/WebKit/UIProcess/API/Cocoa/WKFrameInfo.mm: (-[WKFrameInfo _processIdentifier]): * Source/WebKit/UIProcess/API/Cocoa/_WKFrameTreeNode.mm: (-[_WKFrameTreeNode _processIdentifier]): * Source/WebKit/UIProcess/FrameLoadState.cpp: (WebKit::FrameLoadState::didStartProvisionalLoad): * Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp: (WebKit::ProvisionalFrameProxy::ProvisionalFrameProxy): * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::initializeWebPage): (WebKit::ProvisionalPageProxy::didCreateMainFrame): (WebKit::ProvisionalPageProxy::didCommitLoadForFrame): * Source/WebKit/UIProcess/RemotePageProxy.cpp: (WebKit::RemotePageProxy::RemotePageProxy): (WebKit::RemotePageProxy::injectPageIntoNewProcess): (WebKit::RemotePageProxy::~RemotePageProxy): * Source/WebKit/UIProcess/RemotePageProxy.h: (WebKit::RemotePageProxy::pageID const): (WebKit::RemotePageProxy::domain const): * Source/WebKit/UIProcess/WebFrameProxy.h: (WebKit::WebFrameProxy::setProcess): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::suspendCurrentPageIfPossible): (WebKit::WebPageProxy::commitProvisionalPage): (WebKit::WebPageProxy::shouldClosePreviousPage): (WebKit::WebPageProxy::continueNavigationInNewProcess): (WebKit::WebPageProxy::getAllFrameTrees): (WebKit::WebPageProxy::createNewPage): (WebKit::WebPageProxy::addRemotePageProxy): (WebKit::WebPageProxy::setRemotePageProxyInOpenerProcess): (WebKit::WebPageProxy::addOpenedRemotePageProxy): * Source/WebKit/UIProcess/WebPageProxy.h: * Source/WebKit/UIProcess/WebPageProxyInternals.h: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::processForNavigation): * Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp: (WebKit::WebRemoteFrameClient::changeLocation): * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::info const): (WebKit::WebFrame::didCommitLoadInAnotherProcess): (WebKit::WebFrame::transitionToLocal): * Source/WebKit/WebProcess/WebPage/WebFrame.h: * Source/WebKit/WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::m_appHighlightsVisible): (WebKit::WebPage::didCommitLoadInAnotherProcess): (WebKit::WebPage::transitionFrameToLocal): (WebKit::WebPage::transitionFrameToLocalAndLoadRequest): Deleted. * Source/WebKit/WebProcess/WebPage/WebPage.h: * Source/WebKit/WebProcess/WebPage/WebPage.messages.in: Canonical link: https://commits.webkit.org/265321@main

webkit-commit-queue · 2023-06-20T14:46:44Z

Committed 265321@main (9bcdeaa): https://commits.webkit.org/265321@main

Reviewed commits have been landed. Closing PR #15065 and removing active labels.

achristensen07 requested a review from cdumez as a code owner June 17, 2023 04:25

achristensen07 self-assigned this Jun 17, 2023

achristensen07 added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Jun 17, 2023

achristensen07 mentioned this pull request Jun 17, 2023

Process swap on cross-site window.open behind a flag #10169

Open

achristensen07 force-pushed the eng/Begin-implementing-cross-site-window-open-in-a-new-process branch from 4af069d to 25cd8f2 Compare June 17, 2023 07:10

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 17, 2023

achristensen07 force-pushed the eng/Begin-implementing-cross-site-window-open-in-a-new-process branch from 25cd8f2 to 928eba2 Compare June 17, 2023 21:18

achristensen07 force-pushed the eng/Begin-implementing-cross-site-window-open-in-a-new-process branch from 928eba2 to 61f5b0d Compare June 17, 2023 22:49

achristensen07 removed the merging-blocked Applied to prevent a change from being merged label Jun 17, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 17, 2023

achristensen07 force-pushed the eng/Begin-implementing-cross-site-window-open-in-a-new-process branch from 61f5b0d to cfd18a6 Compare June 17, 2023 23:43

cdumez reviewed Jun 18, 2023

View reviewed changes

cdumez approved these changes Jun 18, 2023

View reviewed changes

achristensen07 force-pushed the eng/Begin-implementing-cross-site-window-open-in-a-new-process branch from cfd18a6 to f39ee89 Compare June 20, 2023 02:04

achristensen07 removed the merging-blocked Applied to prevent a change from being merged label Jun 20, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 20, 2023

achristensen07 added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jun 20, 2023

webkit-commit-queue force-pushed the eng/Begin-implementing-cross-site-window-open-in-a-new-process branch from f39ee89 to 9bcdeaa Compare June 20, 2023 14:46

webkit-commit-queue merged commit 9bcdeaa into WebKit:main Jun 20, 2023

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Begin implementing cross-site window.open in a new process #15065

Begin implementing cross-site window.open in a new process #15065

achristensen07 commented Jun 17, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Jun 17, 2023 •

edited

webkit-early-warning-system commented Jun 17, 2023 •

edited

webkit-early-warning-system commented Jun 17, 2023 •

edited

webkit-early-warning-system commented Jun 17, 2023 •

edited

webkit-early-warning-system commented Jun 17, 2023 •

edited

cdumez Jun 18, 2023

cdumez Jun 18, 2023

achristensen07 Jun 18, 2023

cdumez Jun 18, 2023

achristensen07 Jun 18, 2023

cdumez Jun 18, 2023

achristensen07 Jun 18, 2023

cdumez Jun 18, 2023

cdumez Jun 18, 2023

cdumez left a comment

webkit-early-warning-system commented Jun 20, 2023 •

edited

webkit-commit-queue commented Jun 20, 2023

Begin implementing cross-site window.open in a new process #15065

Begin implementing cross-site window.open in a new process #15065

Conversation

achristensen07 commented Jun 17, 2023 • edited by webkit-early-warning-system

webkit-early-warning-system commented Jun 17, 2023 • edited

webkit-early-warning-system commented Jun 17, 2023 • edited

webkit-early-warning-system commented Jun 17, 2023 • edited

webkit-early-warning-system commented Jun 17, 2023 • edited

webkit-early-warning-system commented Jun 17, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cdumez left a comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Jun 20, 2023 • edited

webkit-commit-queue commented Jun 20, 2023

achristensen07 commented Jun 17, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Jun 17, 2023 •

edited

webkit-early-warning-system commented Jun 17, 2023 •

edited

webkit-early-warning-system commented Jun 17, 2023 •

edited

webkit-early-warning-system commented Jun 17, 2023 •

edited

webkit-early-warning-system commented Jun 17, 2023 •

edited

webkit-early-warning-system commented Jun 20, 2023 •

edited