Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REGRESSION(264714@main) 5% regression in Speedometer 3's Editor-TipTap suite #15078

Conversation

litherum
Copy link
Contributor

@litherum litherum commented Jun 18, 2023

34f8381

REGRESSION(264714@main) 5% regression in Speedometer 3's Editor-TipTap suite
https://bugs.webkit.org/show_bug.cgi?id=258259
rdar://110926113

Reviewed by Ryosuke Niwa.

There's no need to use the fancy NSString subclass if there is no prior context.
The whole reason the NSString subclass exists is to deal with the prior context.
If we can use CFString directly, that's faster.

* Source/WTF/wtf/text/cf/TextBreakIteratorCFCharacterCluster.h:
(WTF::TextBreakIteratorCFCharacterCluster::setText):
* Source/WTF/wtf/text/cf/TextBreakIteratorCFStringTokenizer.h:
(WTF::TextBreakIteratorCFStringTokenizer::TextBreakIteratorCFStringTokenizer):
(WTF::TextBreakIteratorCFStringTokenizer::setText):
(WTF::TextBreakIteratorCFStringTokenizer::createString):

Canonical link: https://commits.webkit.org/265280@main

7056bb3

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2   πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
βœ… πŸ›  πŸ§ͺ jsc   πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  tv-sim βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ›  jsc-mips
βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-mips-tests

@litherum litherum self-assigned this Jun 18, 2023
@litherum litherum added the Text For bugs in text layout and rendering, including international text support. label Jun 18, 2023
@litherum litherum added the merge-queue Applied to send a pull request to merge-queue label Jun 18, 2023
…p suite

https://bugs.webkit.org/show_bug.cgi?id=258259
rdar://110926113

Reviewed by Ryosuke Niwa.

There's no need to use the fancy NSString subclass if there is no prior context.
The whole reason the NSString subclass exists is to deal with the prior context.
If we can use CFString directly, that's faster.

* Source/WTF/wtf/text/cf/TextBreakIteratorCFCharacterCluster.h:
(WTF::TextBreakIteratorCFCharacterCluster::setText):
* Source/WTF/wtf/text/cf/TextBreakIteratorCFStringTokenizer.h:
(WTF::TextBreakIteratorCFStringTokenizer::TextBreakIteratorCFStringTokenizer):
(WTF::TextBreakIteratorCFStringTokenizer::setText):
(WTF::TextBreakIteratorCFStringTokenizer::createString):

Canonical link: https://commits.webkit.org/265280@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION264714main-5-regression-in-Speedometer-3s-Editor-TipTap-suite branch from 7056bb3 to 34f8381 Compare June 18, 2023 03:24
@webkit-commit-queue
Copy link
Collaborator

Committed 265280@main (34f8381): https://commits.webkit.org/265280@main

Reviewed commits have been landed. Closing PR #15078 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 34f8381 into WebKit:main Jun 18, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 18, 2023
@litherum litherum deleted the eng/REGRESSION264714main-5-regression-in-Speedometer-3s-Editor-TipTap-suite branch June 18, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Text For bugs in text layout and rendering, including international text support.
Projects
None yet
4 participants