Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt delegation NEFilterSource SPI #15107

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Adopt delegation NEFilterSource SPI #15107

merged 1 commit into from
Jun 21, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Jun 20, 2023 •
edited by webkit-early-warning-system

238e3a4

Adopt delegation NEFilterSource SPI
https://bugs.webkit.org/show_bug.cgi?id=258304
rdar://109900099

Reviewed by Chris Dumez.

Adopt delegation NEFilterSource SPI, providing audit token of the UI process.

* Source/WebCore/PAL/pal/spi/cocoa/NEFilterSourceSPI.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
* Source/WebKit/Configurations/WebKit.xcconfig:

Canonical link: https://commits.webkit.org/265376@main

0db722a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@pvollan pvollan requested a review from cdumez as a code owner June 20, 2023 16:39
@pvollan pvollan self-assigned this Jun 20, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jun 20, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash cd3bea8)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings   🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ❌ 🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios ❌ 🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-wk2-stress
❌ 🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 20, 2023
@pvollan pvollan removed the merging-blocked Applied to prevent a change from being merged label Jun 20, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 20, 2023
@pvollan pvollan force-pushed the eng/Adopt-delegation-NEFilterSource-SPI branch from cd3bea8 to 55fe850 Compare June 20, 2023 16:51
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 55fe850)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1   🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-wk2-stress
  🛠 watch
❌ 🛠 watch-sim

@pvollan pvollan removed the merging-blocked Applied to prevent a change from being merged label Jun 20, 2023
@pvollan pvollan force-pushed the eng/Adopt-delegation-NEFilterSource-SPI branch from 55fe850 to 144c1ed Compare June 20, 2023 17:22
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 144c1ed)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1   🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 mac-wk2   🧪 api-gtk
⏳ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim ❌ 🧪 mac-wk2-stress
  🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 20, 2023
@pvollan pvollan removed the merging-blocked Applied to prevent a change from being merged label Jun 20, 2023
@pvollan pvollan force-pushed the eng/Adopt-delegation-NEFilterSource-SPI branch from 144c1ed to 0d8ef36 Compare June 20, 2023 18:21
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 0d8ef36)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ❌ 🛠 ios   🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
❌ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
❌ 🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim   🧪 mac-wk2-stress
loading 🛠 watch
❌ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 20, 2023
@pvollan pvollan removed the merging-blocked Applied to prevent a change from being merged label Jun 20, 2023
@pvollan pvollan force-pushed the eng/Adopt-delegation-NEFilterSource-SPI branch from 0d8ef36 to 0db722a Compare June 20, 2023 20:44
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 0db722a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 21, 2023
@pvollan
Copy link
Contributor Author

pvollan commented Jun 21, 2023

Thanks for reviewing!

@pvollan pvollan added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jun 21, 2023
@pvollan
Adopt delegation NEFilterSource SPI
238e3a4 
https://bugs.webkit.org/show_bug.cgi?id=258304
rdar://109900099

Reviewed by Chris Dumez.

Adopt delegation NEFilterSource SPI, providing audit token of the UI process.

* Source/WebCore/PAL/pal/spi/cocoa/NEFilterSourceSPI.h:
* Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
* Source/WebKit/Configurations/WebKit.xcconfig:

Canonical link: https://commits.webkit.org/265376@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Adopt-delegation-NEFilterSource-SPI branch from 0db722a to 238e3a4 Compare June 21, 2023 23:24
@webkit-commit-queue
Copy link
Collaborator

Committed 265376@main (238e3a4): https://commits.webkit.org/265376@main

Reviewed commits have been landed. Closing PR #15107 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 238e3a4 into WebKit:main Jun 21, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

@brentfulgham brentfulgham Awaiting requested review from brentfulgham

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
5 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @cdumez @webkit-ews-buildbot