Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream visionOS-specific AVKit usage #15162

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Upstream visionOS-specific AVKit usage #15162

merged 1 commit into from
Jun 22, 2023

Conversation

pxlcoder
Copy link
Member

@pxlcoder pxlcoder commented Jun 21, 2023 •
edited by webkit-early-warning-system

0e11706

Upstream visionOS-specific AVKit usage
https://bugs.webkit.org/show_bug.cgi?id=258371
rdar://111125631

Reviewed by Tim Horton.

* Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:
* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerViewController initWithFullscreenInterface:]):

Canonical link: https://commits.webkit.org/265384@main

5ee5518

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pxlcoder pxlcoder self-assigned this Jun 21, 2023
@pxlcoder pxlcoder added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 21, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 5ee5518)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@pxlcoder pxlcoder added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 22, 2023
@pxlcoder
Upstream visionOS-specific AVKit usage
0e11706 
https://bugs.webkit.org/show_bug.cgi?id=258371
rdar://111125631

Reviewed by Tim Horton.

* Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:
* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerViewController initWithFullscreenInterface:]):

Canonical link: https://commits.webkit.org/265384@main
@webkit-commit-queue
Copy link
Collaborator

Committed 265384@main (0e11706): https://commits.webkit.org/265384@main

Reviewed commits have been landed. Closing PR #15162 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0e11706 into WebKit:main Jun 22, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@whsieh whsieh Awaiting requested review from whsieh

@megangardner megangardner Awaiting requested review from megangardner

Assignees

@pxlcoder pxlcoder

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
4 participants
@pxlcoder @webkit-early-warning-system @webkit-commit-queue @hortont424