Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional upstream work for visionOS. #15172

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Additional upstream work for visionOS. #15172

merged 1 commit into from
Jun 22, 2023

Conversation

megangardner
Copy link
Contributor

@megangardner megangardner commented Jun 22, 2023 •
edited by webkit-early-warning-system

81ff6b2

Additional upstream work for visionOS.
https://bugs.webkit.org/show_bug.cgi?id=258380
rdar://111134123

Reviewed by Tim Horton.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView _shouldAdditionallyRecognizeGestureRecognizer:simultaneouslyWithGestureRecognizer:]): Deleted.

Canonical link: https://commits.webkit.org/265387@main

ca7bb5a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@megangardner megangardner self-assigned this Jun 22, 2023
@megangardner megangardner added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jun 22, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash ca7bb5a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@megangardner megangardner added the merge-queue Applied to send a pull request to merge-queue label Jun 22, 2023
@megangardner
Additional upstream work for visionOS.
81ff6b2 
https://bugs.webkit.org/show_bug.cgi?id=258380
rdar://111134123

Reviewed by Tim Horton.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView _shouldAdditionallyRecognizeGestureRecognizer:simultaneouslyWithGestureRecognizer:]): Deleted.

Canonical link: https://commits.webkit.org/265387@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Additional-upstream-work-for-visionOS- branch from ca7bb5a to 81ff6b2 Compare June 22, 2023 02:23
@webkit-commit-queue
Copy link
Collaborator

Committed 265387@main (81ff6b2): https://commits.webkit.org/265387@main

Reviewed commits have been landed. Closing PR #15172 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 81ff6b2 into WebKit:main Jun 22, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

Assignees

@megangardner megangardner

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@megangardner @webkit-early-warning-system @webkit-commit-queue @hortont424