Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Support WebM files with no track ID #15193

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

eric-carlson
Copy link
Contributor

@eric-carlson eric-carlson commented Jun 22, 2023

b9047ad

[macOS] Support WebM files with no track ID
https://bugs.webkit.org/show_bug.cgi?id=258402
rdar://110455790

Reviewed by Andy Estes and David Kilzer.

Although WebM track ID is a required header field some otherwise valid files
don't have them. MediaTrackReader requires a track ID, so create an ID when
a file doesn't have one.

* Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp:
(WebKit::MediaFormatReader::didParseTracks):

Canonical link: https://commits.webkit.org/265425@main

fe98fdf

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2   πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@eric-carlson eric-carlson self-assigned this Jun 22, 2023
@eric-carlson eric-carlson added the Media Bugs related to the HTML 5 Media elements. label Jun 22, 2023
@eric-carlson eric-carlson requested a review from aestes June 22, 2023 16:34
Copy link
Contributor

@ddkilzer ddkilzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@ddkilzer
Copy link
Contributor

r=me

Oops, GitHub mobile website makes it harder to spot reviews!

@eric-carlson eric-carlson added the merge-queue Applied to send a pull request to merge-queue label Jun 22, 2023
https://bugs.webkit.org/show_bug.cgi?id=258402
rdar://110455790

Reviewed by Andy Estes and David Kilzer.

Although WebM track ID is a required header field some otherwise valid files
don't have them. MediaTrackReader requires a track ID, so create an ID when
a file doesn't have one.

* Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp:
(WebKit::MediaFormatReader::didParseTracks):

Canonical link: https://commits.webkit.org/265425@main
@webkit-commit-queue
Copy link
Collaborator

Committed 265425@main (b9047ad): https://commits.webkit.org/265425@main

Reviewed commits have been landed. Closing PR #15193 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b9047ad into WebKit:main Jun 22, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
5 participants