Upstream visionOS fullscreen transition logic #15195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxlcoder
added
the
New Bugs
|
EWS run on current version of this PR (hash 4adb8ca)
|
whsieh
approved these changes
Jun 22, 2023
|
|
||
| auto completion = makeBlockPtr([controller = retainPtr(controller), inWindow = retainPtr(inWindow), originalState = retainPtr(originalState), enter, completionHandler = WTFMove(completionHandler)] (BOOL finished) mutable { | ||
| if (!finished) | ||
| return; |
There was a problem hiding this comment.
(Just curious — is it intended to skip the completionHandler in the case of !finished?)
There was a problem hiding this comment.
Not intentional... I should remove this check as the animation isn't intended to be interruptible. Probably better in a follow-up, to avoid mixing with upstreaming.
There was a problem hiding this comment.
Yep! Definitely good to keep this upstreaming patch as-is.
https://bugs.webkit.org/show_bug.cgi?id=258404 rdar://111164029 Reviewed by Wenson Hsieh. * Source/WebKit/Platform/spi/visionos/MRUIKitSPI.h: Added. * Source/WebKit/Platform/spi/visionos/RealitySimulationServicesSPI.h: Added. * Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (WebKit::useSpatialFullScreenTransition): (WebKit::resizeScene): (-[WKFixedSizeWindow _shouldResizeWithScene]): (-[WKFullScreenParentWindowState initWithWindow:]): (-[WKFullscreenWindowSceneDelegate initWithController:originalDelegate:]): (-[WKFullscreenWindowSceneDelegate originalDelegate]): (-[WKFullscreenWindowSceneDelegate windowScene:shouldCloseForReason:]): (-[WKFullscreenWindowSceneDelegate methodSignatureForSelector:]): (-[WKFullscreenWindowSceneDelegate respondsToSelector:]): (-[WKFullscreenWindowSceneDelegate forwardInvocation:]): (-[WKFullscreenWindowSceneDelegate forwardingTargetForSelector:]): (-[WKFullScreenWindowController enterFullScreen:]): (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): (-[WKFullScreenWindowController _completedExitFullScreen]): (-[WKFullScreenWindowController _exitFullscreenImmediately]): (-[WKFullScreenWindowController _dismissFullscreenViewController]): (-[WKFullScreenWindowController _configureSpatialFullScreenTransition]): (-[WKFullScreenWindowController _performSpatialFullScreenTransition:completionHandler:]): * Source/WebKit/WebKit.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/265416@main
webkit-commit-queue
force-pushed
the
eng/258404
branch
from
4adb8ca
to
9866948
Compare
|
Committed 265416@main (9866948): https://commits.webkit.org/265416@main Reviewed commits have been landed. Closing PR #15195 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9866948
4adb8ca
🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 mac-AS-debug-wk2