Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cocoa] Delete dead code after cleaning up HAVE() and USE() macros #15225

Conversation

litherum
Copy link
Contributor

@litherum litherum commented Jun 23, 2023

6a90e53

[Cocoa] Delete dead code after cleaning up HAVE() and USE() macros
https://bugs.webkit.org/show_bug.cgi?id=258436
rdar://111198556

Reviewed by Tim Horton and Alexey Proskuryakov.

Now that we've removed a bunch of configurations, there is a bunch of
leftover dead code we can remove.

* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/runtime/SymbolStubsForSafariCompatibility.mm: Removed.
* Source/WTF/wtf/PlatformHave.h:
* Source/WTF/wtf/PlatformUse.h:
* Source/WTF/wtf/text/WTFString.h:
* Source/WTF/wtf/text/cocoa/StringCocoa.mm:
(WTF::String::String): Deleted.
* Source/WebCore/PAL/pal/cf/CoreTextSoftLink.cpp:
* Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:
* Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:
* Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h:
* Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h:
* Source/WebCore/PAL/pal/spi/mac/QuickLookMacSPI.h:
* Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::SystemFontDatabaseCoreText::createTextStyleFont):
(WebCore::mapWidth):
* Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::createCFStorageSessionForIdentifier):
* Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::createPrivateStorageSession):
* Source/WebKit/GPUProcess/mac/GPUProcessMac.mm:
(WebKit::GPUProcess::initializeSandbox):
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
(WebKit::NetworkRTCUDPSocketCocoaConnections::createNWConnection):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCUtilitiesCocoa.mm:
(WebKit::setNWParametersApplicationIdentifiers):
(WebKit::setNWParametersTrackerOptions):
(WebKit::isKnownTracker):
* Source/WebKit/Platform/spi/Cocoa/AccessibilitySupportSPI.h:
* Source/WebKit/Platform/spi/Cocoa/NWSPI.h:
* Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h:
* Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::initializeSandbox):
* Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:

Canonical link: https://commits.webkit.org/265448@main

aba13a2

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe   πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ§ͺ api-ios   πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  tv-sim βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch βœ… πŸ›  jsc-mips
βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-mips-tests

@litherum litherum requested review from cdumez and a team as code owners June 23, 2023 04:36
@litherum litherum self-assigned this Jun 23, 2023
@litherum litherum added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jun 23, 2023
@litherum litherum force-pushed the eng/Cocoa-Delete-dead-code-after-cleaning-up-HAVE-and-USE-macros branch from a8344a0 to 26031ee Compare June 23, 2023 04:58
@litherum litherum force-pushed the eng/Cocoa-Delete-dead-code-after-cleaning-up-HAVE-and-USE-macros branch from 26031ee to aba13a2 Compare June 23, 2023 05:11
@litherum litherum added the merge-queue Applied to send a pull request to merge-queue label Jun 23, 2023
https://bugs.webkit.org/show_bug.cgi?id=258436
rdar://111198556

Reviewed by Tim Horton and Alexey Proskuryakov.

Now that we've removed a bunch of configurations, there is a bunch of
leftover dead code we can remove.

* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/runtime/SymbolStubsForSafariCompatibility.mm: Removed.
* Source/WTF/wtf/PlatformHave.h:
* Source/WTF/wtf/PlatformUse.h:
* Source/WTF/wtf/text/WTFString.h:
* Source/WTF/wtf/text/cocoa/StringCocoa.mm:
(WTF::String::String): Deleted.
* Source/WebCore/PAL/pal/cf/CoreTextSoftLink.cpp:
* Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h:
* Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:
* Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h:
* Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h:
* Source/WebCore/PAL/pal/spi/mac/QuickLookMacSPI.h:
* Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:
(WebCore::SystemFontDatabaseCoreText::createTextStyleFont):
(WebCore::mapWidth):
* Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::createCFStorageSessionForIdentifier):
* Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:
(WebCore::createPrivateStorageSession):
* Source/WebKit/GPUProcess/mac/GPUProcessMac.mm:
(WebKit::GPUProcess::initializeSandbox):
* Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
(WebKit::NetworkRTCUDPSocketCocoaConnections::createNWConnection):
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCUtilitiesCocoa.mm:
(WebKit::setNWParametersApplicationIdentifiers):
(WebKit::setNWParametersTrackerOptions):
(WebKit::isKnownTracker):
* Source/WebKit/Platform/spi/Cocoa/AccessibilitySupportSPI.h:
* Source/WebKit/Platform/spi/Cocoa/NWSPI.h:
* Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h:
* Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::initializeSandbox):
* Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:

Canonical link: https://commits.webkit.org/265448@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Cocoa-Delete-dead-code-after-cleaning-up-HAVE-and-USE-macros branch from aba13a2 to 6a90e53 Compare June 23, 2023 06:35
@webkit-commit-queue
Copy link
Collaborator

Committed 265448@main (6a90e53): https://commits.webkit.org/265448@main

Reviewed commits have been landed. Closing PR #15225 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6a90e53 into WebKit:main Jun 23, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 23, 2023
@litherum litherum deleted the eng/Cocoa-Delete-dead-code-after-cleaning-up-HAVE-and-USE-macros branch June 23, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
5 participants