-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cocoa] Delete dead code after cleaning up HAVE() and USE() macros #15225
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
litherum:eng/Cocoa-Delete-dead-code-after-cleaning-up-HAVE-and-USE-macros
Jun 23, 2023
Merged
[Cocoa] Delete dead code after cleaning up HAVE() and USE() macros #15225
webkit-commit-queue
merged 1 commit into
WebKit:main
from
litherum:eng/Cocoa-Delete-dead-code-after-cleaning-up-HAVE-and-USE-macros
Jun 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash a8344a0) |
hortont424
approved these changes
Jun 23, 2023
aproskuryakov
approved these changes
Jun 23, 2023
a8344a0
to
26031ee
Compare
EWS run on previous version of this PR (hash 26031ee) |
litherum
commented
Jun 23, 2023
litherum
commented
Jun 23, 2023
26031ee
to
aba13a2
Compare
https://bugs.webkit.org/show_bug.cgi?id=258436 rdar://111198556 Reviewed by Tim Horton and Alexey Proskuryakov. Now that we've removed a bunch of configurations, there is a bunch of leftover dead code we can remove. * Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: * Source/JavaScriptCore/runtime/SymbolStubsForSafariCompatibility.mm: Removed. * Source/WTF/wtf/PlatformHave.h: * Source/WTF/wtf/PlatformUse.h: * Source/WTF/wtf/text/WTFString.h: * Source/WTF/wtf/text/cocoa/StringCocoa.mm: (WTF::String::String): Deleted. * Source/WebCore/PAL/pal/cf/CoreTextSoftLink.cpp: * Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h: * Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h: * Source/WebCore/PAL/pal/spi/mac/HIToolboxSPI.h: * Source/WebCore/PAL/pal/spi/mac/NSWindowSPI.h: * Source/WebCore/PAL/pal/spi/mac/QuickLookMacSPI.h: * Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp: (WebCore::SystemFontDatabaseCoreText::createTextStyleFont): (WebCore::mapWidth): * Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp: (WebCore::NetworkStorageSession::createCFStorageSessionForIdentifier): * Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm: (WebCore::createPrivateStorageSession): * Source/WebKit/GPUProcess/mac/GPUProcessMac.mm: (WebKit::GPUProcess::initializeSandbox): * Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm: (WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): * Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm: (WebKit::NetworkRTCUDPSocketCocoaConnections::createNWConnection): * Source/WebKit/NetworkProcess/webrtc/NetworkRTCUtilitiesCocoa.mm: (WebKit::setNWParametersApplicationIdentifiers): (WebKit::setNWParametersTrackerOptions): (WebKit::isKnownTracker): * Source/WebKit/Platform/spi/Cocoa/AccessibilitySupportSPI.h: * Source/WebKit/Platform/spi/Cocoa/NWSPI.h: * Source/WebKit/Platform/spi/mac/ApplicationServicesSPI.h: * Source/WebKit/UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm: * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::initializeSandbox): * Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Canonical link: https://commits.webkit.org/265448@main
aba13a2
to
6a90e53
Compare
Committed 265448@main (6a90e53): https://commits.webkit.org/265448@main Reviewed commits have been landed. Closing PR #15225 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6a90e53
aba13a2
π wincairoπ§ͺ wpe-wk2π§ͺ gtk-wk2π§ͺ mac-wk2π§ͺ mac-AS-debug-wk2