Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert r295516 and r295373 #1526

Merged
merged 0 commits into from Jun 15, 2022
Merged

Revert r295516 and r295373 #1526

merged 0 commits into from Jun 15, 2022

Conversation

heycam
Copy link
Contributor

@heycam heycam commented Jun 15, 2022 •
edited by webkit-early-warning-system

4960495

Revert r295516 and r295373
https://bugs.webkit.org/show_bug.cgi?id=241621

Unreviewed, reverts:

r295516 "Make TextRun::isolatedCopy copy character data in more cases"
r295373 "Add a new DrawDecomposedGlyphs display list item to avoid repeatedly sending glyphs when using the GlyphDisplayListCache"

Canonical link: https://commits.webkit.org/251551@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@heycam heycam self-assigned this Jun 15, 2022
@heycam heycam added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 15, 2022
@webkit-early-warning-system
Copy link
Collaborator

No reviewer information in commit message, blocking PR #1526

@webkit-early-warning-system webkit-early-warning-system added merging-blocked Applied to prevent a change from being merged and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Jun 15, 2022
@heycam heycam removed the merging-blocked Applied to prevent a change from being merged label Jun 15, 2022
@heycam heycam force-pushed the eng/Revert-r295516-incomplete-fix branch from a45b94b to ef4aec1 Compare June 15, 2022 00:42
@heycam heycam changed the title Revert "Make TextRun::isolatedCopy copy character data in more cases" Revert " Jun 15, 2022
@heycam heycam added Layout and Rendering For bugs with layout and rendering of Web pages. WebKit Local Build labels Jun 15, 2022
@heycam heycam changed the title Revert " Revert r295373 and r295516 Jun 15, 2022
@heycam heycam added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 15, 2022
@heycam heycam force-pushed the eng/Revert-r295516-incomplete-fix branch from ef4aec1 to 9b620cb Compare June 15, 2022 00:47
@heycam heycam changed the title Revert r295373 and r295516 Revert r295516 and r295373 Jun 15, 2022
@heycam heycam added merge-queue Applied to send a pull request to merge-queue unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing merge-queue Applied to send a pull request to merge-queue labels Jun 15, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 4960495 into WebKit:main Jun 15, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r295546 (251551@main): https://commits.webkit.org/251551@main

Reviewed commits have been landed. Closing PR #1526 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
2 participants
@heycam @webkit-early-warning-system