Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Use more specific zero-clearing pattern in MacroAssembler #15277

Merged
merged 1 commit into from
Jun 26, 2023
Merged

[JSC] Use more specific zero-clearing pattern in MacroAssembler #15277

merged 1 commit into from
Jun 26, 2023

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Jun 25, 2023 •
edited by webkit-early-warning-system

dcb1617

[JSC] Use more specific zero-clearing pattern in MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=258497
rdar://problem/111282793

Reviewed by Keith Miller.

Use the most efficient & CPU friendly instruction for zero-clearing registers.

* Source/JavaScriptCore/assembler/ARM64Assembler.h:
* Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::moveZeroToDouble):
(JSC::MacroAssemblerARM64::moveZeroToFloat):
(JSC::MacroAssemblerARM64::move):
(JSC::MacroAssemblerARM64::moveZeroToVector):

Canonical link: https://commits.webkit.org/265522@main

c8e238a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@Constellation Constellation requested a review from a team as a code owner June 25, 2023 08:33
@Constellation Constellation self-assigned this Jun 25, 2023
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jun 25, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash c8e238a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

hyjorc1
hyjorc1 reviewed Jun 26, 2023
View reviewed changes
Source/JavaScriptCore/assembler/MacroAssemblerARM64.h
if (src != dest)
m_assembler.mov<64>(dest, src);
if (src != dest) {
if (src == ARM64Registers::zr && dest != ARM64Registers::sp)
Copy link
Contributor

@hyjorc1 hyjorc1 Jun 26, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can we not move 0 to sp?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sp is special register, and we cannot use as a target of movz on ARM64.

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 26, 2023
@Constellation
[JSC] Use more specific zero-clearing pattern in MacroAssembler
dcb1617 
https://bugs.webkit.org/show_bug.cgi?id=258497
rdar://problem/111282793

Reviewed by Keith Miller.

Use the most efficient & CPU friendly instruction for zero-clearing registers.

* Source/JavaScriptCore/assembler/ARM64Assembler.h:
* Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::moveZeroToDouble):
(JSC::MacroAssemblerARM64::moveZeroToFloat):
(JSC::MacroAssemblerARM64::move):
(JSC::MacroAssemblerARM64::moveZeroToVector):

Canonical link: https://commits.webkit.org/265522@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Use-more-specific-zero-clearing-pattern-in-MacroAssembler branch from c8e238a to dcb1617 Compare June 26, 2023 18:03
@webkit-commit-queue
Copy link
Collaborator

Committed 265522@main (dcb1617): https://commits.webkit.org/265522@main

Reviewed commits have been landed. Closing PR #15277 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit dcb1617 into WebKit:main Jun 26, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 26, 2023
@Constellation Constellation deleted the eng/JSC-Use-more-specific-zero-clearing-pattern-in-MacroAssembler branch June 26, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyjorc1 hyjorc1 hyjorc1 left review comments

@kmiller68 kmiller68 kmiller68 approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
5 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @kmiller68 @hyjorc1