Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Use dup-and-ins instead of ins-and-ins to construct SIMD vector #15278

Merged
merged 1 commit into from
Jun 26, 2023
Merged

[JSC] Use dup-and-ins instead of ins-and-ins to construct SIMD vector #15278

merged 1 commit into from
Jun 26, 2023

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Jun 25, 2023 •
edited by webkit-early-warning-system

d6403c4

[JSC] Use dup-and-ins instead of ins-and-ins to construct SIMD vector
https://bugs.webkit.org/show_bug.cgi?id=258498
rdar://111283281

Reviewed by Michael Saboff.

Use DUP-and-INS instead of INS-and-INS to remove partial dependency to the old vector value.

* Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::materializeVector):
* Source/JavaScriptCore/b3/air/AirLowerMacros.cpp:
(JSC::B3::Air::lowerMacros):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::addSIMDShift):
(JSC::Wasm::BBQJIT::emitVectorMul):

Canonical link: https://commits.webkit.org/265520@main

59f0816

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@Constellation Constellation requested a review from a team as a code owner June 25, 2023 08:53
@Constellation Constellation self-assigned this Jun 25, 2023
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jun 25, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash d2cb631)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
❌ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
❌ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@Constellation Constellation force-pushed the eng/JSC-Use-dup-and-ins-instead-of-ins-and-ins-to-construct-SIMD-vector branch from d2cb631 to fd6227f Compare June 25, 2023 18:43
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash fd6227f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
✅ 🛠 🧪 jsc   🧪 api-ios   🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@Constellation Constellation force-pushed the eng/JSC-Use-dup-and-ins-instead-of-ins-and-ins-to-construct-SIMD-vector branch from fd6227f to 59f0816 Compare June 25, 2023 19:00
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 59f0816)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

msaboff
msaboff approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@msaboff msaboff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 26, 2023
@Constellation
[JSC] Use dup-and-ins instead of ins-and-ins to construct SIMD vector
d6403c4 
https://bugs.webkit.org/show_bug.cgi?id=258498
rdar://111283281

Reviewed by Michael Saboff.

Use DUP-and-INS instead of INS-and-INS to remove partial dependency to the old vector value.

* Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::materializeVector):
* Source/JavaScriptCore/b3/air/AirLowerMacros.cpp:
(JSC::B3::Air::lowerMacros):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::addSIMDShift):
(JSC::Wasm::BBQJIT::emitVectorMul):

Canonical link: https://commits.webkit.org/265520@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Use-dup-and-ins-instead-of-ins-and-ins-to-construct-SIMD-vector branch from 59f0816 to d6403c4 Compare June 26, 2023 17:46
@webkit-commit-queue
Copy link
Collaborator

Committed 265520@main (d6403c4): https://commits.webkit.org/265520@main

Reviewed commits have been landed. Closing PR #15278 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit d6403c4 into WebKit:main Jun 26, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 26, 2023
@Constellation Constellation deleted the eng/JSC-Use-dup-and-ins-instead-of-ins-and-ins-to-construct-SIMD-vector branch June 26, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaboff msaboff msaboff approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @msaboff