Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the background responsiveness timer when RunningBoard is used #15306

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Jun 26, 2023

4224c4b

Disable the background responsiveness timer when RunningBoard is used
https://bugs.webkit.org/show_bug.cgi?id=258534

Reviewed by Ben Nham.

Disable the background responsiveness timer when RunningBoard is used. We used
to only disable it on iOS because we only used RunningBoard on iOS. However,
now that we use RunningBoard on macOS too, we should disable it on this
platform too. Background processes now get a very low priority and eventually
get suspended. This would cause false reports of unresponsive processes.

* Source/WebKit/UIProcess/BackgroundProcessResponsivenessTimer.cpp:
(WebKit::BackgroundProcessResponsivenessTimer::shouldBeActive const):

Canonical link: https://commits.webkit.org/265536@main

7c85ff1

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@cdumez cdumez self-assigned this Jun 26, 2023
@cdumez cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label Jun 26, 2023
@cdumez cdumez requested a review from bnham June 26, 2023 21:59
Copy link
Contributor

@bnham bnham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Jun 27, 2023
https://bugs.webkit.org/show_bug.cgi?id=258534

Reviewed by Ben Nham.

Disable the background responsiveness timer when RunningBoard is used. We used
to only disable it on iOS because we only used RunningBoard on iOS. However,
now that we use RunningBoard on macOS too, we should disable it on this
platform too. Background processes now get a very low priority and eventually
get suspended. This would cause false reports of unresponsive processes.

* Source/WebKit/UIProcess/BackgroundProcessResponsivenessTimer.cpp:
(WebKit::BackgroundProcessResponsivenessTimer::shouldBeActive const):

Canonical link: https://commits.webkit.org/265536@main
@webkit-commit-queue webkit-commit-queue force-pushed the 258534_disable_BackgroundResponsiveness branch from 7c85ff1 to 4224c4b Compare June 27, 2023 03:39
@webkit-commit-queue
Copy link
Collaborator

Committed 265536@main (4224c4b): https://commits.webkit.org/265536@main

Reviewed commits have been landed. Closing PR #15306 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4224c4b into WebKit:main Jun 27, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
4 participants