Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GStreamer] Check Dolby features data ignoring case #15323

Merged
merged 1 commit into from
Jun 27, 2023
Merged

[GStreamer] Check Dolby features data ignoring case #15323

merged 1 commit into from
Jun 27, 2023

Conversation

calvaris
Copy link
Contributor

@calvaris calvaris commented Jun 27, 2023 •
edited by webkit-early-warning-system

12a85d6

[GStreamer] Check Dolby features data ignoring case
https://bugs.webkit.org/show_bug.cgi?id=258555

Reviewed by Philippe Normand.

Dolby features data can come in different case and it is still valid.

Based on a patch by Jack Howgate <jack.howgate@sky.uk>.

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::supportsFeatures const):

Canonical link: https://commits.webkit.org/265544@main

d0d9d53

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@calvaris calvaris requested a review from philn as a code owner June 27, 2023 10:39
@calvaris calvaris self-assigned this Jun 27, 2023
@calvaris calvaris added the Media Bugs related to the HTML 5 Media elements. label Jun 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash d0d9d53)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@calvaris calvaris added the merge-queue Applied to send a pull request to merge-queue label Jun 27, 2023
@calvaris
[GStreamer] Check Dolby features data ignoring case
12a85d6 
https://bugs.webkit.org/show_bug.cgi?id=258555

Reviewed by Philippe Normand.

Dolby features data can come in different case and it is still valid.

Based on a patch by Jack Howgate <jack.howgate@sky.uk>.

* Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::supportsFeatures const):

Canonical link: https://commits.webkit.org/265544@main
@webkit-commit-queue
Copy link
Collaborator

Committed 265544@main (12a85d6): https://commits.webkit.org/265544@main

Reviewed commits have been landed. Closing PR #15323 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 12a85d6 into WebKit:main Jun 27, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 27, 2023
@calvaris calvaris mentioned this pull request Jun 28, 2023
Closed
@calvaris calvaris deleted the eng/258555 branch June 28, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philn philn philn approved these changes

Assignees

@calvaris calvaris

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
4 participants
@calvaris @webkit-early-warning-system @webkit-commit-queue @philn