Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Fold GetArrayLength(String) in DFG #15394

Merged
merged 1 commit into from
Jun 29, 2023
Merged

[JSC] Fold GetArrayLength(String) in DFG #15394

merged 1 commit into from
Jun 29, 2023

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Jun 29, 2023 •
edited by webkit-early-warning-system

1dd4e87

[JSC] Fold GetArrayLength(String) in DFG
https://bugs.webkit.org/show_bug.cgi?id=258657
rdar://111492563

Reviewed by Michael Saboff.

Add DFG AI rule which folds GetArrayLength(constant-string) to constant number since String's length is immutable.

* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

Canonical link: https://commits.webkit.org/265613@main

67a5c63

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@Constellation Constellation requested a review from a team as a code owner June 29, 2023 04:11
@Constellation Constellation self-assigned this Jun 29, 2023
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Jun 29, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 67a5c63)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

msaboff
msaboff approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@msaboff msaboff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 29, 2023
@Constellation
[JSC] Fold GetArrayLength(String) in DFG
1dd4e87 
https://bugs.webkit.org/show_bug.cgi?id=258657
rdar://111492563

Reviewed by Michael Saboff.

Add DFG AI rule which folds GetArrayLength(constant-string) to constant number since String's length is immutable.

* Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

Canonical link: https://commits.webkit.org/265613@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/JSC-Fold-GetArrayLengthString-in-DFG branch from 67a5c63 to 1dd4e87 Compare June 29, 2023 07:09
@webkit-commit-queue
Copy link
Collaborator

Committed 265613@main (1dd4e87): https://commits.webkit.org/265613@main

Reviewed commits have been landed. Closing PR #15394 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1dd4e87 into WebKit:main Jun 29, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaboff msaboff msaboff approved these changes

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @msaboff