Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Inspector: inspector/page/setShowPaintRects.html is a flakey failure since introduction #1541

Conversation

patrickangle
Copy link
Contributor

@patrickangle patrickangle commented Jun 15, 2022

07992b5

Web Inspector: inspector/page/setShowPaintRects.html is a flakey failure since introduction
https://bugs.webkit.org/show_bug.cgi?id=233047
rdar://85345706

Reviewed by Antoine Quint.

Adding test results to the page causes a paint to be scheduled, which can cause paint rects to be requested at times we
are not expecting them as part of the flow of the test. We expect only our explicit change to an element to cause paints
to occur, but currently those paints end up interleaved with paints for adding results to the test page.

To resolve this, we now defer writing results to the test page until the end of each test case. This allows us to wait
to start each test case until there are no paint rects, and to avoid accidently causing a paint rect to appear at
inopportune times for our testing.

* LayoutTests/inspector/page/setShowPaintRects-expected.txt:
* LayoutTests/inspector/page/setShowPaintRects.html:
* LayoutTests/platform/mac/TestExpectations:

Canonical link: https://commits.webkit.org/251585@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@295580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@patrickangle patrickangle self-assigned this Jun 15, 2022
@patrickangle patrickangle added Web Inspector Bugs related to the WebKit Web Inspector. WebKit Nightly Build labels Jun 15, 2022
Copy link
Contributor

@graouts graouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@patrickangle patrickangle force-pushed the eng/b233047-setShowPaintRects-flakeyfailure branch from 8119eeb to 0913080 Compare June 15, 2022 20:47
@patrickangle patrickangle added merge-queue Applied to send a pull request to merge-queue labels Jun 15, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/b233047-setShowPaintRects-flakeyfailure branch from 0913080 to 07992b5 Compare June 15, 2022 23:55
@webkit-early-warning-system webkit-early-warning-system merged commit 07992b5 into WebKit:main Jun 15, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r295580 (251585@main): https://commits.webkit.org/251585@main

Reviewed commits have been landed. Closing PR #1541 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Jun 15, 2022
@patrickangle patrickangle deleted the eng/b233047-setShowPaintRects-flakeyfailure branch June 16, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
3 participants