Videos autoplay with sound on cnn.com pages after refresh in Safari #15423

jernoble · 2023-06-29T22:08:39Z

`f4cdea7`

Videos autoplay with sound on cnn.com pages after refresh in Safari
https://bugs.webkit.org/show_bug.cgi?id=258696
rdar://110343800

Reviewed by Chris Dumez.

The HTML specification defines a very narrow set of gesture events
which will cause activation. WebKit currently triggers activation
for all uses of UserGestureIndicator, which leads to things like
"LeftCmd Up" after a Cmd-R to trigger playback during a reload.

Add a set of helper methods `userGestureTypeForPlatformEvent()` to
return the correct UserGestureType for a particular PlatformEvent.

Update UserGestureIndicator to only set the activation timestamp of
the window when passed a UserGestureType::ActivationTriggering.

Make UserGestureType::ActivationTriggering the default to handle
the currently large set of call sites that expect a user gesture
to be triggered from a programmatic call.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-keyboard-enter-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-keyboard-escape-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-mouse-left-expected.txt:
* Source/WebCore/dom/UserGestureIndicator.cpp:
* Source/WebCore/dom/UserGestureIndicator.h:
* Source/WebCore/page/EventHandler.cpp:
(WebCore::userGestureTypeForPlatformEvent):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::internalKeyEvent):
(WebCore::EventHandler::handleTouchEvent):

Canonical link: https://commits.webkit.org/265688@main

e012322

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-06-29T22:09:02Z

EWS run on previous version of this PR (hash c3e08e5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

cdumez

LGTM if the bots are happy.

cdumez · 2023-06-30T02:15:04Z

Source/WebCore/dom/UserGestureIndicator.cpp

-        if (auto* window = document->domWindow())
+        // https://html.spec.whatwg.org/multipage/interaction.html#user-activation-processing-model
+        // When a user interaction causes firing of an activation triggering input event in a Document...
+        // NOTE: Only activate the relevent DOMWindow when the gestureType is an ActivationTriggering one


typo: relevent

webkit-early-warning-system · 2023-06-30T06:07:35Z

EWS run on previous version of this PR (hash 51232c5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-06-30T15:36:32Z

EWS run on previous version of this PR (hash 97acabf)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 wincairo~~
~~🧪 bindings~~	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🛠 gtk~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-06-30T15:37:56Z

EWS run on previous version of this PR (hash 06433aa)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-06-30T18:29:10Z

EWS run on previous version of this PR (hash 28177ab)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-06-30T21:47:03Z

EWS run on previous version of this PR (hash 186d761)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-06-30T22:04:30Z

EWS run on current version of this PR (hash e012322)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=258696 rdar://110343800 Reviewed by Chris Dumez. The HTML specification defines a very narrow set of gesture events which will cause activation. WebKit currently triggers activation for all uses of UserGestureIndicator, which leads to things like "LeftCmd Up" after a Cmd-R to trigger playback during a reload. Add a set of helper methods `userGestureTypeForPlatformEvent()` to return the correct UserGestureType for a particular PlatformEvent. Update UserGestureIndicator to only set the activation timestamp of the window when passed a UserGestureType::ActivationTriggering. Make UserGestureType::ActivationTriggering the default to handle the currently large set of call sites that expect a user gesture to be triggered from a programmatic call. * LayoutTests/TestExpectations: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-keyboard-enter-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-keyboard-escape-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/user-activation/activation-trigger-mouse-left-expected.txt: * Source/WebCore/dom/UserGestureIndicator.cpp: * Source/WebCore/dom/UserGestureIndicator.h: * Source/WebCore/page/EventHandler.cpp: (WebCore::userGestureTypeForPlatformEvent): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::internalKeyEvent): (WebCore::EventHandler::handleTouchEvent): Canonical link: https://commits.webkit.org/265688@main

webkit-commit-queue · 2023-07-01T18:33:28Z

Committed 265688@main (f4cdea7): https://commits.webkit.org/265688@main

Reviewed commits have been landed. Closing PR #15423 and removing active labels.

jernoble requested review from cdumez and rniwa as code owners June 29, 2023 22:08

jernoble self-assigned this Jun 29, 2023

jernoble added the Media Bugs related to the HTML 5 Media elements. label Jun 29, 2023

jernoble requested review from eric-carlson and brentfulgham June 29, 2023 22:09

cdumez approved these changes Jun 29, 2023

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 30, 2023

cdumez reviewed Jun 30, 2023

View reviewed changes

jernoble removed the merging-blocked Applied to prevent a change from being merged label Jun 30, 2023

jernoble force-pushed the eng/Videos-autoplay-with-sound-on-cnn-com-pages-after-refresh-in-Safari branch from c3e08e5 to 51232c5 Compare June 30, 2023 06:07

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 30, 2023

jernoble removed the merging-blocked Applied to prevent a change from being merged label Jun 30, 2023

jernoble force-pushed the eng/Videos-autoplay-with-sound-on-cnn-com-pages-after-refresh-in-Safari branch from 51232c5 to 97acabf Compare June 30, 2023 15:36

jernoble force-pushed the eng/Videos-autoplay-with-sound-on-cnn-com-pages-after-refresh-in-Safari branch from 97acabf to 06433aa Compare June 30, 2023 15:37

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 30, 2023

jernoble removed the merging-blocked Applied to prevent a change from being merged label Jun 30, 2023

jernoble force-pushed the eng/Videos-autoplay-with-sound-on-cnn-com-pages-after-refresh-in-Safari branch from 06433aa to 28177ab Compare June 30, 2023 18:28

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 30, 2023

jernoble removed the merging-blocked Applied to prevent a change from being merged label Jun 30, 2023

jernoble force-pushed the eng/Videos-autoplay-with-sound-on-cnn-com-pages-after-refresh-in-Safari branch from 28177ab to 186d761 Compare June 30, 2023 21:46

jernoble force-pushed the eng/Videos-autoplay-with-sound-on-cnn-com-pages-after-refresh-in-Safari branch from 186d761 to e012322 Compare June 30, 2023 22:04

eric-carlson added the merge-queue Applied to send a pull request to merge-queue label Jul 1, 2023

webkit-commit-queue force-pushed the eng/Videos-autoplay-with-sound-on-cnn-com-pages-after-refresh-in-Safari branch from e012322 to f4cdea7 Compare July 1, 2023 18:33

webkit-commit-queue merged commit f4cdea7 into WebKit:main Jul 1, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 1, 2023

jernoble deleted the eng/Videos-autoplay-with-sound-on-cnn-com-pages-after-refresh-in-Safari branch October 26, 2023 15:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Videos autoplay with sound on cnn.com pages after refresh in Safari #15423

Videos autoplay with sound on cnn.com pages after refresh in Safari #15423

jernoble commented Jun 29, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Jun 29, 2023 •

edited

Loading

cdumez left a comment

cdumez Jun 30, 2023

webkit-early-warning-system commented Jun 30, 2023 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2023 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2023 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2023 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2023 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2023 •

edited

Loading

webkit-commit-queue commented Jul 1, 2023

Videos autoplay with sound on cnn.com pages after refresh in Safari #15423

Videos autoplay with sound on cnn.com pages after refresh in Safari #15423

Conversation

jernoble commented Jun 29, 2023 • edited by webkit-early-warning-system Loading

f4cdea7

webkit-early-warning-system commented Jun 29, 2023 • edited Loading

cdumez left a comment

Choose a reason for hiding this comment

cdumez Jun 30, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Jun 30, 2023 • edited Loading

webkit-early-warning-system commented Jun 30, 2023 • edited Loading

webkit-early-warning-system commented Jun 30, 2023 • edited Loading

webkit-early-warning-system commented Jun 30, 2023 • edited Loading

webkit-early-warning-system commented Jun 30, 2023 • edited Loading

webkit-early-warning-system commented Jun 30, 2023 • edited Loading

webkit-commit-queue commented Jul 1, 2023

jernoble commented Jun 29, 2023 •

edited by webkit-early-warning-system

Loading

`f4cdea7`

webkit-early-warning-system commented Jun 29, 2023 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2023 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2023 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2023 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2023 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2023 •

edited

Loading

webkit-early-warning-system commented Jun 30, 2023 •

edited

Loading