Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scrollbar-gutter on viewports #15459

Closed
wants to merge 1 commit into from

Conversation

lukewarlow
Copy link
Member

@lukewarlow lukewarlow commented Jun 30, 2023

ccc39c2

Implement scrollbar-gutter on viewports
https://bugs.webkit.org/show_bug.cgi?id=257606

Reviewed by NOBODY (OOPS!).

Updates scrollbar gutter implementation to work for viewports.

* Source/WebCore/platform/ScrollView.cpp:
(WebCore::ScrollView::documentScrollPositionRelativeToViewOrigin const):
(WebCore::ScrollView::verticalScrollbarWidth const):
(WebCore::ScrollView::horizontalScrollbarHeight const):
(WebCore::ScrollView::locationOfContents const):
* Source/WebCore/platform/ScrollView.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::includeVerticalScrollbarSize const):

ccc39c2

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug ❌ πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt ❌ πŸ§ͺ mac-wk1 βœ… πŸ›  gtk
βœ… πŸ§ͺ api-ios ❌ πŸ§ͺ mac-wk2 ❌ πŸ§ͺ gtk-wk2
βœ… πŸ›  tv ❌ πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv-sim
βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@lukewarlow lukewarlow self-assigned this Jun 30, 2023
@lukewarlow lukewarlow added the CSS Cascading Style Sheets implementation label Jun 30, 2023
@lukewarlow
Copy link
Member Author

lukewarlow commented Jun 30, 2023

TODO:

  • Extract out improved style resolution into separate PR

  • Fix build failure

  • Work out why the tests fail, (offsetWidth doesn't seem to correctly account for scrollbar gutters)

  • Work out why there's a double gutter if a scrollbar is rendering (overflow: scroll or an overflowing viewport)

  • Cleanup code some of these changes are probably not neccesary

  • Add more tests for viewport scrollbar-gutter usage (such as testing both-edges)

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 30, 2023
@lukewarlow
Copy link
Member Author

Closing for now will reopen soon. Extracting the improvement of the style resolution into its own PR.

@lukewarlow lukewarlow closed this Jul 8, 2023
@lukewarlow lukewarlow reopened this Jul 14, 2023
@lukewarlow lukewarlow removed the merging-blocked Applied to prevent a change from being merged label Jul 14, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jul 14, 2023
@lukewarlow lukewarlow closed this Aug 14, 2023
@lukewarlow lukewarlow reopened this Oct 12, 2023
@lukewarlow lukewarlow removed the merging-blocked Applied to prevent a change from being merged label Oct 12, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 13, 2023
@lukewarlow lukewarlow closed this Oct 13, 2023
https://bugs.webkit.org/show_bug.cgi?id=257606

Reviewed by NOBODY (OOPS!).

Updates scrollbar gutter implementation to work for viewports.

* Source/WebCore/platform/ScrollView.cpp:
(WebCore::ScrollView::documentScrollPositionRelativeToViewOrigin const):
(WebCore::ScrollView::verticalScrollbarWidth const):
(WebCore::ScrollView::horizontalScrollbarHeight const):
(WebCore::ScrollView::locationOfContents const):
* Source/WebCore/platform/ScrollView.h:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::includeVerticalScrollbarSize const):
@lukewarlow lukewarlow reopened this Feb 9, 2024
@lukewarlow lukewarlow added skip-ews Applied to prevent a change from being run on EWS and removed merging-blocked Applied to prevent a change from being merged skip-ews Applied to prevent a change from being run on EWS labels Feb 9, 2024
@lukewarlow
Copy link
Member Author

TODO re-evaluate current state of this and work out next steps to completion.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 9, 2024
@lukewarlow lukewarlow closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation merging-blocked Applied to prevent a change from being merged
Projects
None yet
3 participants