Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Controls: Interaction region on visionOS <audio> volume button is too big #15483

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

rr-codes
Copy link
Contributor

@rr-codes rr-codes commented Jul 1, 2023

aede64d

Media Controls: Interaction region on visionOS <audio> volume button is too big
https://bugs.webkit.org/show_bug.cgi?id=258772
rdar://110499146

Reviewed by Tim Horton.

The existing padding and margins of the media control bar buttons were designed for button and bar
sizes of the <video> element, which are larger than those of the <audio> element. This caused the
interaction regions of all the audio control bar buttons to be larger than they should.

Fix by reducing the padding to compensate and match the ratio of the <video> buttons' padding, and
adjust the margins to maintain concentricity with the controls bar.

* Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.css:
(.media-controls.vision.audio > .bottom.controls-bar,):
(.media-controls.vision.audio > .bottom.controls-bar button):
(.media-controls.vision.audio > .bottom.controls-bar button.mute):
(.media-controls.vision.audio > .bottom.controls-bar .buttons-container.left):
(.media-controls.vision.audio > .bottom.controls-bar .buttons-container.right):

Canonical link: https://commits.webkit.org/265739@main

dab4497

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@rr-codes rr-codes self-assigned this Jul 1, 2023
@rr-codes rr-codes added the Media Bugs related to the HTML 5 Media elements. label Jul 1, 2023
@rr-codes rr-codes added the merge-queue Applied to send a pull request to merge-queue label Jul 3, 2023
…is too big

https://bugs.webkit.org/show_bug.cgi?id=258772
rdar://110499146

Reviewed by Tim Horton.

The existing padding and margins of the media control bar buttons were designed for button and bar
sizes of the <video> element, which are larger than those of the <audio> element. This caused the
interaction regions of all the audio control bar buttons to be larger than they should.

Fix by reducing the padding to compensate and match the ratio of the <video> buttons' padding, and
adjust the margins to maintain concentricity with the controls bar.

* Source/WebCore/Modules/modern-media-controls/controls/vision-media-controls.css:
(.media-controls.vision.audio > .bottom.controls-bar,):
(.media-controls.vision.audio > .bottom.controls-bar button):
(.media-controls.vision.audio > .bottom.controls-bar button.mute):
(.media-controls.vision.audio > .bottom.controls-bar .buttons-container.left):
(.media-controls.vision.audio > .bottom.controls-bar .buttons-container.right):

Canonical link: https://commits.webkit.org/265739@main
@webkit-commit-queue
Copy link
Collaborator

Committed 265739@main (aede64d): https://commits.webkit.org/265739@main

Reviewed commits have been landed. Closing PR #15483 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit aede64d into WebKit:main Jul 4, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
4 participants