Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.window.js to work around Safari SVG specificites #15499

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Jul 3, 2023

17c12a1

Update LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.window.js to work around Safari SVG specificites
https://bugs.webkit.org/show_bug.cgi?id=258803
rdar://111679627

Reviewed by Eric Carlson.

Without a renderer and being in the DOM, SVG image element is not firing the load event, and does not have a cached image.
We update the test accoridngly, since the goal is to validate timestamps.
Bugs have been filed to track Safari SVG specifities.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.window.js:
(promise_test.async t):

Canonical link: https://commits.webkit.org/265724@main

cb2aef0

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@youennf youennf self-assigned this Jul 3, 2023
@youennf youennf added the Media Bugs related to the HTML 5 Media elements. label Jul 3, 2023
@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Jul 3, 2023
…me-construction.window.js to work around Safari SVG specificites

https://bugs.webkit.org/show_bug.cgi?id=258803
rdar://111679627

Reviewed by Eric Carlson.

Without a renderer and being in the DOM, SVG image element is not firing the load event, and does not have a cached image.
We update the test accoridngly, since the goal is to validate timestamps.
Bugs have been filed to track Safari SVG specifities.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.window.js:
(promise_test.async t):

Canonical link: https://commits.webkit.org/265724@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Update-LayoutTestsimportedw3cweb-platform-testswebcodecsvideoFrame-construction-window-js-to-work-around-Safari-SVG-specificites branch from cb2aef0 to 17c12a1 Compare July 3, 2023 17:18
@webkit-commit-queue
Copy link
Collaborator

Committed 265724@main (17c12a1): https://commits.webkit.org/265724@main

Reviewed commits have been landed. Closing PR #15499 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 17c12a1 into WebKit:main Jul 3, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
4 participants